Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): add docs extraction for type aliases #52118

Closed
wants to merge 1 commit into from
Closed

feat(compiler): add docs extraction for type aliases #52118

wants to merge 1 commit into from

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Oct 9, 2023

No description provided.

@jelbourn jelbourn added area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release labels Oct 9, 2023
@jelbourn jelbourn requested a review from atscott October 9, 2023 20:50
@ngbot ngbot bot modified the milestone: Backlog Oct 9, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 9, 2023
@jelbourn
feat(compiler): add docs extraction for type aliases
6eb87c1 
This commit adds support for extracting type alises. It currently
extracts the raw written type from the source without performing any
resolution, such as for resolving `typeof` queries, as current Angular
public APIs do not rely on this.
@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Oct 10, 2023
@jelbourn
Copy link
Member Author

Caretaker note: Windows CI is a flake

@angular-robot
Copy link
Contributor

angular-robot bot commented Oct 10, 2023

This PR was merged into the repository by commit 1934524.

@angular-robot angular-robot bot closed this in 1934524 Oct 10, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@jelbourn @ChellappanRajan
feat(compiler): add docs extraction for type aliases (angular#52118)
38b5720 
This commit adds support for extracting type alises. It currently
extracts the raw written type from the source without performing any
resolution, such as for resolving `typeof` queries, as current Angular
public APIs do not rely on this.

PR Close angular#52118
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jelbourn @atscott