Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): allow newlines in track and let expressions #52137

Closed
wants to merge 1 commit into from
Closed

fix(compiler): allow newlines in track and let expressions #52137

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Fixes that the template parser didn't allow for newlines in the track and let expressions of @for blocks.

Fixes #52132.

@crisbeto
fix(compiler): allow newlines in track and let expressions
7ddd6fb 
Fixes that the template parser didn't allow for newlines in the `track` and `let` expressions of `@for` blocks.

Fixes angular#52132.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 10, 2023
@ngbot ngbot bot modified the milestone: Backlog Oct 10, 2023
@crisbeto crisbeto marked this pull request as ready for review October 10, 2023 12:54
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 10, 2023
@crisbeto
Copy link
Member Author

Caretaker note: this passes all the checks, except the usual Windows flakes.

@alxhub alxhub modified the milestones: Backlog, v17-candidates Oct 10, 2023
@angular-robot angular-robot bot closed this in 7dbd47f Oct 10, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@crisbeto @ChellappanRajan
fix(compiler): allow newlines in track and let expressions (angular#5…
4e93a3d 
…2137)

Fixes that the template parser didn't allow for newlines in the `track` and `let` expressions of `@for` blocks.

Fixes angular#52132.

PR Close angular#52137
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v17-candidates
Development

Successfully merging this pull request may close these issues.

Parser error for line break when creating composite key using @for
3 participants
@crisbeto @AndrewKushnir @alxhub