Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(language-service): Complete @case inside @switch #52153

Closed
wants to merge 1 commit into from
Closed

feat(language-service): Complete @case inside @switch #52153

wants to merge 1 commit into from

Conversation

dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Oct 10, 2023

We now visit the unknown nodes inside a @switch block, enabling completions in that context.

@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release labels Oct 10, 2023
@dylhunn dylhunn requested a review from atscott October 10, 2023 23:47
@ngbot ngbot bot added this to the Backlog milestone Oct 10, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 10, 2023
@dylhunn dylhunn force-pushed the ls-blocks branch 2 times, most recently from 0bfcbf2 to 18abb5a Compare October 10, 2023 23:51
@dylhunn dylhunn changed the title feat(language-service): Complete inside @switch feat(language-service): Complete @case inside @switch Oct 10, 2023
@dylhunn
feat(language-service): Complete inside @switch
58d52df 
We now visit the unknown nodes inside a `@switch` block, enabling completions in that context.
@dylhunn dylhunn removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 10, 2023
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 10, 2023
@dylhunn dylhunn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 11, 2023
@dylhunn
Copy link
Contributor Author

dylhunn commented Oct 11, 2023

caretaker: saucelabs is a flake

@angular-robot angular-robot bot closed this in 449830f Oct 11, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@dylhunn @ChellappanRajan
feat(language-service): Complete inside @switch (angular#52153)
a99dd2c 
We now visit the unknown nodes inside a `@switch` block, enabling completions in that context.

PR Close angular#52153
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dylhunn @atscott