fix(compiler): avoid error in template parser for tag names that can occur in object prototype #52225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…occur in object prototype Fixes that the compiler was throwing an error if an element tag name is the same as a built-in prototype property (e.g. `constructor` or `toString`). The problem was that we were storing the tag names in an object literal with the `Object` prototype. These changes resolve the issue by creating an object without a prototype. Fixes angular#52224.
crisbeto
added
action: review
crisbeto
commented
Oct 16, 2023
| @@ -75,7 +75,7 @@ let TAG_DEFINITIONS!: {[key: string]: HtmlTagDefinition}; | |||
| export function getHtmlTagDefinition(tagName: string): HtmlTagDefinition { | |||
| if (!TAG_DEFINITIONS) { | |||
| DEFAULT_TAG_DEFINITION = new HtmlTagDefinition({canSelfClose: true}); | |||
| TAG_DEFINITIONS = { | |||
| TAG_DEFINITIONS = Object.assign(Object.create(null), { | |||
There was a problem hiding this comment.
Another way to fix the issue is to check with hasOwnProperty before each lookup. I went with this approach, because it only needs to happen once when we construct the object, rather than every time we look up a tag name.
crisbeto
added
target: patch
atscott
approved these changes
Oct 16, 2023
atscott
added
action: merge
|
@crisbeto it looks like it doesn't merge cleanly into 16.2 - any objections to re-targetting it to RC ? Then you could open a separate PR targeting 16.2 (or just not have this fix in 16.x ???) |
|
It's fixing a bit of an edge case so I'm fine with targeting it to the RC. |
crisbeto
added
target: rc
|
This PR was merged into the repository by commit 302ab34. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Oct 16, 2023
…occur in object prototype (#52225) Fixes that the compiler was throwing an error if an element tag name is the same as a built-in prototype property (e.g. `constructor` or `toString`). The problem was that we were storing the tag names in an object literal with the `Object` prototype. These changes resolve the issue by creating an object without a prototype. Fixes #52224. PR Close #52225
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…occur in object prototype (angular#52225) Fixes that the compiler was throwing an error if an element tag name is the same as a built-in prototype property (e.g. `constructor` or `toString`). The problem was that we were storing the tag names in an object literal with the `Object` prototype. These changes resolve the issue by creating an object without a prototype. Fixes angular#52224. PR Close angular#52225
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the compiler was throwing an error if an element tag name is the same as a built-in prototype property (e.g.
constructorortoString). The problem was that we were storing the tag names in an object literal with theObjectprototype. These changes resolve the issue by creating an object without a prototype.Fixes #52224.