Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nested classes in migrations #52309

Closed
wants to merge 2 commits into from
Closed

Handle nested classes in migrations #52309

wants to merge 2 commits into from

Conversation

crisbeto
Copy link
Member

Updates a couple of migrations that were only looking at classes defined at the top level of the file.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: migrations Issues related to `ng update` migrations target: rc This PR is targeted for the next release-candidate labels Oct 21, 2023
@ngbot ngbot bot modified the milestone: Backlog Oct 21, 2023
@crisbeto crisbeto modified the milestones: Backlog, v17-final Oct 24, 2023
jessicajaniuk
jessicajaniuk approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 24, 2023
@crisbeto
fix(migrations): handle nested classes in block entities migration
9d72c41 
Fixes that the block entities migration was only processing top-level classes. Nested classes could come up during unit tests.
@crisbeto
fix(migrations): handle nested classes in control flow migration
2b82d34 
Fixes that the control flow migration was only processing top-level classes. Nested classes could come up during unit tests.
@crisbeto crisbeto added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 24, 2023
@crisbeto
Copy link
Member Author

Caretaker note: this one passed the presubmit earlier, but I had to push again to resolve merge conflicts.

@dylhunn
Copy link
Contributor

dylhunn commented Oct 24, 2023

This PR was merged into the repository by commit c993e9a.

dylhunn pushed a commit that referenced this pull request Oct 24, 2023
@crisbeto @dylhunn
fix(migrations): handle nested classes in block entities migration (#…
54bc384 
…52309)

Fixes that the block entities migration was only processing top-level classes. Nested classes could come up during unit tests.

PR Close #52309
dylhunn pushed a commit that referenced this pull request Oct 24, 2023
@crisbeto @dylhunn
fix(migrations): handle nested classes in control flow migration (#52309
c9b1ddf 
)

Fixes that the control flow migration was only processing top-level classes. Nested classes could come up during unit tests.

PR Close #52309
@dylhunn dylhunn closed this in 9e76468 Oct 24, 2023
dylhunn pushed a commit that referenced this pull request Oct 24, 2023
@crisbeto @dylhunn
fix(migrations): handle nested classes in control flow migration (#52309
c993e9a 
)

Fixes that the control flow migration was only processing top-level classes. Nested classes could come up during unit tests.

PR Close #52309
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2023
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
@crisbeto @tbondwilkinson
fix(migrations): handle nested classes in block entities migration (a…
c3e6eb9 
…ngular#52309)

Fixes that the block entities migration was only processing top-level classes. Nested classes could come up during unit tests.

PR Close angular#52309
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
@crisbeto @tbondwilkinson
fix(migrations): handle nested classes in control flow migration (ang…
d36c919 
…ular#52309)

Fixes that the control flow migration was only processing top-level classes. Nested classes could come up during unit tests.

PR Close angular#52309
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@crisbeto @ChellappanRajan
fix(migrations): handle nested classes in block entities migration (a…
98116d1 
…ngular#52309)

Fixes that the block entities migration was only processing top-level classes. Nested classes could come up during unit tests.

PR Close angular#52309
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@crisbeto @ChellappanRajan
fix(migrations): handle nested classes in control flow migration (ang…
f599145 
…ular#52309)

Fixes that the control flow migration was only processing top-level classes. Nested classes could come up during unit tests.

PR Close angular#52309
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
v17-final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @dylhunn @jessicajaniuk