fix(core): some edge cases in DI debug APIs #52365

AleksanderBodurri · 2023-10-25T04:17:25Z

See individual commits

…d with `providedIn` Previously this case was missed by the default framework injector profiler. Now in ngDevMode this event emits correctly when a service is configured with `providedIn`. This includes the case where injection tokens are configured with a `providedIn`. This commit also includes unit tests for this new case in the injector profiler.

Previously, because the platform injector does not have a provider container, this API would fail. Now, we account for this case specifically by returning the found providers immediately, without trying to calculate their importpaths. Also previously, in the case where a boostrapped standalone component did not import any feature modules, the environment injector connected to that bootstrapped component would be the root injector configured by `bootstrapApplication`. This injector is configured through a `providers` array instead of an `imports` array, and also does not have a provider container. Similarly to the platform case, we account this for this by returning the found providers immediately if there is no provider container for our standalone component.

… standalone case This is needed so that the providers configured on platform creation are picked up by the injector profiler.

dylhunn · 2023-10-25T17:51:27Z

This PR was merged into the repository by commit 8ee0f27.

…d with `providedIn` (#52365) Previously this case was missed by the default framework injector profiler. Now in ngDevMode this event emits correctly when a service is configured with `providedIn`. This includes the case where injection tokens are configured with a `providedIn`. This commit also includes unit tests for this new case in the injector profiler. PR Close #52365

…52365) Previously, because the platform injector does not have a provider container, this API would fail. Now, we account for this case specifically by returning the found providers immediately, without trying to calculate their importpaths. Also previously, in the case where a boostrapped standalone component did not import any feature modules, the environment injector connected to that bootstrapped component would be the root injector configured by `bootstrapApplication`. This injector is configured through a `providers` array instead of an `imports` array, and also does not have a provider container. Similarly to the platform case, we account this for this by returning the found providers immediately if there is no provider container for our standalone component. PR Close #52365

… standalone case (#52365) This is needed so that the providers configured on platform creation are picked up by the injector profiler. PR Close #52365

…52365) Previously, because the platform injector does not have a provider container, this API would fail. Now, we account for this case specifically by returning the found providers immediately, without trying to calculate their importpaths. Also previously, in the case where a boostrapped standalone component did not import any feature modules, the environment injector connected to that bootstrapped component would be the root injector configured by `bootstrapApplication`. This injector is configured through a `providers` array instead of an `imports` array, and also does not have a provider container. Similarly to the platform case, we account this for this by returning the found providers immediately if there is no provider container for our standalone component. PR Close #52365

… standalone case (#52365) This is needed so that the providers configured on platform creation are picked up by the injector profiler. PR Close #52365

…d with `providedIn` (#52365) Previously this case was missed by the default framework injector profiler. Now in ngDevMode this event emits correctly when a service is configured with `providedIn`. This includes the case where injection tokens are configured with a `providedIn`. This commit also includes unit tests for this new case in the injector profiler. PR Close #52365

…52365) Previously, because the platform injector does not have a provider container, this API would fail. Now, we account for this case specifically by returning the found providers immediately, without trying to calculate their importpaths. Also previously, in the case where a boostrapped standalone component did not import any feature modules, the environment injector connected to that bootstrapped component would be the root injector configured by `bootstrapApplication`. This injector is configured through a `providers` array instead of an `imports` array, and also does not have a provider container. Similarly to the platform case, we account this for this by returning the found providers immediately if there is no provider container for our standalone component. PR Close #52365

… standalone case (#52365) This is needed so that the providers configured on platform creation are picked up by the injector profiler. PR Close #52365

angular-automatic-lock-bot · 2023-11-25T00:08:44Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…d with `providedIn` (angular#52365) Previously this case was missed by the default framework injector profiler. Now in ngDevMode this event emits correctly when a service is configured with `providedIn`. This includes the case where injection tokens are configured with a `providedIn`. This commit also includes unit tests for this new case in the injector profiler. PR Close angular#52365

…ngular#52365) Previously, because the platform injector does not have a provider container, this API would fail. Now, we account for this case specifically by returning the found providers immediately, without trying to calculate their importpaths. Also previously, in the case where a boostrapped standalone component did not import any feature modules, the environment injector connected to that bootstrapped component would be the root injector configured by `bootstrapApplication`. This injector is configured through a `providers` array instead of an `imports` array, and also does not have a provider container. Similarly to the platform case, we account this for this by returning the found providers immediately if there is no provider container for our standalone component. PR Close angular#52365

… standalone case (angular#52365) This is needed so that the providers configured on platform creation are picked up by the injector profiler. PR Close angular#52365

…d with `providedIn` (angular#52365) Previously this case was missed by the default framework injector profiler. Now in ngDevMode this event emits correctly when a service is configured with `providedIn`. This includes the case where injection tokens are configured with a `providedIn`. This commit also includes unit tests for this new case in the injector profiler. PR Close angular#52365

…ngular#52365) Previously, because the platform injector does not have a provider container, this API would fail. Now, we account for this case specifically by returning the found providers immediately, without trying to calculate their importpaths. Also previously, in the case where a boostrapped standalone component did not import any feature modules, the environment injector connected to that bootstrapped component would be the root injector configured by `bootstrapApplication`. This injector is configured through a `providers` array instead of an `imports` array, and also does not have a provider container. Similarly to the platform case, we account this for this by returning the found providers immediately if there is no provider container for our standalone component. PR Close angular#52365

… standalone case (angular#52365) This is needed so that the providers configured on platform creation are picked up by the injector profiler. PR Close angular#52365

AleksanderBodurri requested a review from AndrewKushnir October 25, 2023 04:17

AleksanderBodurri added the target: patch This PR is targeted for the next patch release label Oct 25, 2023

AleksanderBodurri force-pushed the di-debug-api-fixes branch from 128edfc to 16ee1ea Compare October 25, 2023 04:40

AleksanderBodurri changed the title ~~fix(core): emit provider configured event when a service is configured with providedIn~~ fix(core): some edge cases in DI debug APIs Oct 25, 2023

AleksanderBodurri added 3 commits October 25, 2023 02:22

fix(core): load global utils before creating platform injector in the…

17576b6

… standalone case This is needed so that the providers configured on platform creation are picked up by the injector profiler.

AleksanderBodurri force-pushed the di-debug-api-fixes branch from 16ee1ea to 17576b6 Compare October 25, 2023 06:23

dylhunn added area: core Issues related to the framework runtime core: di labels Oct 25, 2023

ngbot bot modified the milestone: Backlog Oct 25, 2023

AndrewKushnir approved these changes Oct 25, 2023

View reviewed changes

AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Oct 25, 2023

dylhunn closed this in 31b8870 Oct 25, 2023

AleksanderBodurri deleted the di-debug-api-fixes branch October 25, 2023 18:03

angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): some edge cases in DI debug APIs #52365

fix(core): some edge cases in DI debug APIs #52365

AleksanderBodurri commented Oct 25, 2023 •

edited

dylhunn commented Oct 25, 2023

angular-automatic-lock-bot bot commented Nov 25, 2023

fix(core): some edge cases in DI debug APIs #52365

fix(core): some edge cases in DI debug APIs #52365

Conversation

AleksanderBodurri commented Oct 25, 2023 • edited

dylhunn commented Oct 25, 2023

angular-automatic-lock-bot bot commented Nov 25, 2023

AleksanderBodurri commented Oct 25, 2023 •

edited