Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): Ensure control flow migration ignores new block syntax #52402

Closed
wants to merge 1 commit into from

Conversation

jessicajaniuk
Copy link
Contributor

This fix ensures that the control flow migration does not encounter any problems when new block sytax already exists in a template.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer area: migrations Issues related to `ng update` migrations target: rc This PR is targeted for the next release-candidate labels Oct 26, 2023
@ngbot ngbot bot modified the milestone: Backlog Oct 26, 2023
@jessicajaniuk jessicajaniuk modified the milestones: Backlog, v17-final Oct 26, 2023
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one non-blocking question.

This fix ensures that the control flow migration does not encounter any problems when new block sytax already exists in a template.
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 26, 2023
@alxhub
Copy link
Member

alxhub commented Oct 27, 2023

This PR was merged into the repository by commit fa03f0a.

@alxhub alxhub closed this in fa03f0a Oct 27, 2023
alxhub pushed a commit that referenced this pull request Oct 27, 2023
…ax (#52402)

This fix ensures that the control flow migration does not encounter any problems when new block sytax already exists in a template.

PR Close #52402
@jessicajaniuk jessicajaniuk deleted the migration-blocks branch November 9, 2023 20:34
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
…ax (angular#52402)

This fix ensures that the control flow migration does not encounter any problems when new block sytax already exists in a template.

PR Close angular#52402
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…ax (angular#52402)

This fix ensures that the control flow migration does not encounter any problems when new block sytax already exists in a template.

PR Close angular#52402
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants