docs(core): Deprecate ChangeDetectorRef.checkNoChanges
#52431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
detected: deprecation
atscott
changed the title
ChangeDetectorRef.checkNoChangesChangeDetectorRef.checkNoChanges
atscott
force-pushed
the
deprecateChangeDetectorRefDetectChanges
branch
from
09593d3
to
abd9d56
Compare
pkozlowski-opensource
approved these changes
Oct 30, 2023
|
cleanup: CI is read (needs |
pkozlowski-opensource
added
the
action: cleanup
The `checkNoChanges` method does not belong in the API of production interface. `checkNoChanges` is limited to testing and should not be used in any application code. Test code should use `ComponentFixture` instead of `ChangeDetectorRef`. Additionally, it is not desirable to have the `checkNoChanges` API available in a context where `detectChanges` is not run first. DEPRECATED: `ChangeDetectorRef.checkNoChanges` is deprecated. Test code should use `ComponentFixture` instead of `ChangeDetectorRef`. Application code should not call `ChangeDetectorRef.checkNoChanges` directly.
atscott
force-pushed
the
deprecateChangeDetectorRefDetectChanges
branch
from
abd9d56
to
4c83a28
Compare
pullapprove
bot
requested review from
alxhub,
jessicajaniuk and
pkozlowski-opensource
jessicajaniuk
approved these changes
Oct 30, 2023
atscott
added
action: merge
|
caretaker note: docs only, no need for g3 tests |
pkozlowski-opensource
approved these changes
Oct 31, 2023
|
This PR was merged into the repository by commit 75725fb. |
alxhub
pushed a commit
that referenced
this pull request
Oct 31, 2023
The `checkNoChanges` method does not belong in the API of production interface. `checkNoChanges` is limited to testing and should not be used in any application code. Test code should use `ComponentFixture` instead of `ChangeDetectorRef`. Additionally, it is not desirable to have the `checkNoChanges` API available in a context where `detectChanges` is not run first. DEPRECATED: `ChangeDetectorRef.checkNoChanges` is deprecated. Test code should use `ComponentFixture` instead of `ChangeDetectorRef`. Application code should not call `ChangeDetectorRef.checkNoChanges` directly. PR Close #52431
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
The `checkNoChanges` method does not belong in the API of production interface. `checkNoChanges` is limited to testing and should not be used in any application code. Test code should use `ComponentFixture` instead of `ChangeDetectorRef`. Additionally, it is not desirable to have the `checkNoChanges` API available in a context where `detectChanges` is not run first. DEPRECATED: `ChangeDetectorRef.checkNoChanges` is deprecated. Test code should use `ComponentFixture` instead of `ChangeDetectorRef`. Application code should not call `ChangeDetectorRef.checkNoChanges` directly. PR Close angular#52431
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
The `checkNoChanges` method does not belong in the API of production interface. `checkNoChanges` is limited to testing and should not be used in any application code. Test code should use `ComponentFixture` instead of `ChangeDetectorRef`. Additionally, it is not desirable to have the `checkNoChanges` API available in a context where `detectChanges` is not run first. DEPRECATED: `ChangeDetectorRef.checkNoChanges` is deprecated. Test code should use `ComponentFixture` instead of `ChangeDetectorRef`. Application code should not call `ChangeDetectorRef.checkNoChanges` directly. PR Close angular#52431
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
checkNoChangesmethod does not belong in the API of production interface.checkNoChangesis limited to testing and should not be used in any application code. Test code should useComponentFixtureinstead ofChangeDetectorRef. Additionally, it is not desirable to have thecheckNoChangesAPI available in a context wheredetectChangesis not run first.DEPRECATED:
ChangeDetectorRef.checkNoChangesis deprecated.Test code should use
ComponentFixtureinstead ofChangeDetectorRef. Application code should not callChangeDetectorRef.checkNoChangesdirectly.