fix(core): use TNode instead of LView for mapping injector providers #52436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksanderBodurri
changed the title
AleksanderBodurri
force-pushed
the
di-get-providers-fixes
branch
from
d44e988
to
62cc6ee
Compare
AleksanderBodurri
added
target: patch
AleksanderBodurri
force-pushed
the
di-get-providers-fixes
branch
from
62cc6ee
to
00b651f
Compare
AleksanderBodurri
force-pushed
the
di-get-providers-fixes
branch
from
00b651f
to
1d11cbe
Compare
AleksanderBodurri
changed the title
AleksanderBodurri
force-pushed
the
di-get-providers-fixes
branch
from
1d11cbe
to
aef433a
Compare
Previously, LViews were used here to be consistent with other debug APIs. Using LViews for tracking injector providers does not work because providers only get configured once per TNode type. Now we use the TNode as the key to track element injector providers, allowing the injector for each item rendered in a list (`ngFor` or `@for`) to be targeted with debug APIs for inspecting providers
AleksanderBodurri
force-pushed
the
di-get-providers-fixes
branch
from
aef433a
to
24c0eac
Compare
AndrewKushnir
changed the title
AndrewKushnir
approved these changes
Oct 30, 2023
AndrewKushnir
added
the
action: presubmit
AndrewKushnir
added
action: merge
atscott
added
target: rc
|
@AleksanderBodurri updated target to |
|
This PR was merged into the repository by commit 3d73b0c. |
atscott
pushed a commit
that referenced
this pull request
Nov 3, 2023
…52436) Previously, LViews were used here to be consistent with other debug APIs. Using LViews for tracking injector providers does not work because providers only get configured once per TNode type. Now we use the TNode as the key to track element injector providers, allowing the injector for each item rendered in a list (`ngFor` or `@for`) to be targeted with debug APIs for inspecting providers PR Close #52436
Abseil-byte
pushed a commit
to Abseil-byte/angular
that referenced
this pull request
Nov 5, 2023
…ngular#52436) Previously, LViews were used here to be consistent with other debug APIs. Using LViews for tracking injector providers does not work because providers only get configured once per TNode type. Now we use the TNode as the key to track element injector providers, allowing the injector for each item rendered in a list (`ngFor` or `@for`) to be targeted with debug APIs for inspecting providers PR Close angular#52436
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…ngular#52436) Previously, LViews were used here to be consistent with other debug APIs. Using LViews for tracking injector providers does not work because providers only get configured once per TNode type. Now we use the TNode as the key to track element injector providers, allowing the injector for each item rendered in a list (`ngFor` or `@for`) to be targeted with debug APIs for inspecting providers PR Close angular#52436
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ngular#52436) Previously, LViews were used here to be consistent with other debug APIs. Using LViews for tracking injector providers does not work because providers only get configured once per TNode type. Now we use the TNode as the key to track element injector providers, allowing the injector for each item rendered in a list (`ngFor` or `@for`) to be targeted with debug APIs for inspecting providers PR Close angular#52436
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, LViews were used here to be consistent with other debug APIs. Using LViews for tracking injector providers does not work because providers only get configured once per TNode type.
Now we use the TNode as the key to track element injector providers, allowing the injector for each item rendered in a list (
ngForor@for) to be targeted with debug APIs for inspecting providers