fix(core): handle aliased index with no space in control flow migration #52444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current regexp supposes that there is at least one space between the `=` and the aliased variable. As it is possible to write `let myIndex=index`, this commit updates the regexp to handle such a case.
crisbeto
added
action: merge
|
This PR was merged into the repository by commit c5980d6. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…on (angular#52444) The current regexp supposes that there is at least one space between the `=` and the aliased variable. As it is possible to write `let myIndex=index`, this commit updates the regexp to handle such a case. PR Close angular#52444
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…on (angular#52444) The current regexp supposes that there is at least one space between the `=` and the aliased variable. As it is possible to write `let myIndex=index`, this commit updates the regexp to handle such a case. PR Close angular#52444
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current regexp supposes that there is at least one space between the
=and the aliased variable.What is the new behavior?
As it is possible to write
let myIndex=index, this commit updates the regexp to handle such a case.Does this PR introduce a breaking change?
Other information