fix(core): mutation bug in getDependenciesFromInjectable
#52450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksanderBodurri
added
target: patch
Previously, we would modified `dep.flags` directly to convert injection flags to booleans. This caused a mutation bug where subsequent calls to `getDependenciesFromInjectable` would result in the flags object containing false for every injection flag. Now, we stop modifying `dep.flags` directly and instead assign the converted flags to a new object.
AleksanderBodurri
force-pushed
the
di-get-injected-deps-fix
branch
from
7c8a8fe
to
e01a5ed
Compare
AndrewKushnir
approved these changes
Oct 30, 2023
AndrewKushnir
added
the
action: presubmit
AndrewKushnir
added
action: merge
|
@AleksanderBodurri FYI this change has merge conflicts with 16.2.x branch (so it'd be merged into 17.0.x and main branches only), please create a new PR for 16.2.x if needed. |
|
This PR was merged into the repository by commit 078ebea. |
alxhub
pushed a commit
that referenced
this pull request
Oct 31, 2023
Previously, we would modified `dep.flags` directly to convert injection flags to booleans. This caused a mutation bug where subsequent calls to `getDependenciesFromInjectable` would result in the flags object containing false for every injection flag. Now, we stop modifying `dep.flags` directly and instead assign the converted flags to a new object. PR Close #52450
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…2450) Previously, we would modified `dep.flags` directly to convert injection flags to booleans. This caused a mutation bug where subsequent calls to `getDependenciesFromInjectable` would result in the flags object containing false for every injection flag. Now, we stop modifying `dep.flags` directly and instead assign the converted flags to a new object. PR Close angular#52450
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…2450) Previously, we would modified `dep.flags` directly to convert injection flags to booleans. This caused a mutation bug where subsequent calls to `getDependenciesFromInjectable` would result in the flags object containing false for every injection flag. Now, we stop modifying `dep.flags` directly and instead assign the converted flags to a new object. PR Close angular#52450
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would modified
dep.flagsdirectly to convert injection flags to booleans. This caused a mutation bug where subsequent calls togetDependenciesFromInjectablewould result in the flags object containing false for every injection flag.Now, we stop modifying
dep.flagsdirectly and instead assign the converted flags to a new object.