fix(core): guard usages of performance.mark
#52505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
alan-agius4
force-pushed
the
performance-mark-guarded
branch
from
a7c4e21
to
99e36d4
Compare
alan-agius4
changed the title
performance.markperformance.mark
alan-agius4
added
area: core
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
performance-mark-guarded
branch
from
99e36d4
to
bcef20d
Compare
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Nov 3, 2023
More context in angular/angular#52505
pkozlowski-opensource
approved these changes
Nov 3, 2023
alan-agius4
requested review from
devversion
and removed request for
AndrewKushnir and
josephperrott
alan-agius4
added a commit
to angular/angular-cli
that referenced
this pull request
Nov 3, 2023
More context in angular/angular#52505 (cherry picked from commit 5f14bf3)
alan-agius4
added a commit
to angular/angular-cli
that referenced
this pull request
Nov 3, 2023
More context in angular/angular#52505
devversion
reviewed
Nov 3, 2023
While `performance.mark` is available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker. This commit, updates the usage to a safer variant.
alxhub
approved these changes
Nov 3, 2023
While `performance.mark` is available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker.
alan-agius4
force-pushed
the
performance-mark-guarded
branch
from
8e5cae1
to
fd2a147
Compare
devversion
approved these changes
Nov 3, 2023
alan-agius4
removed
the
action: review
|
This PR was merged into the repository by commit d4bd3f1. |
atscott
pushed a commit
that referenced
this pull request
Nov 3, 2023
While `performance.mark` is available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker. PR Close #52505
atscott
pushed a commit
that referenced
this pull request
Nov 3, 2023
While `performance.mark` is available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker. This commit, updates the usage to a safer variant. PR Close #52505
atscott
pushed a commit
that referenced
this pull request
Nov 3, 2023
While `performance.mark` is available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker. PR Close #52505
| markName: string, | ||
| markOptions?: PerformanceMarkOptions|undefined, | ||
| ): PerformanceMark|undefined { | ||
| return performance?.mark?.(markName, markOptions); |
There was a problem hiding this comment.
Sorry for the late comment. I'm wondering if we should make it even safer by checking if the performance is defined as a global first, i.e.:
return typeof performance !== 'undefined' ? performance.mark?.(markName, markOptions) : undefined;
@alan-agius4 WDYT?
There was a problem hiding this comment.
So far I didn’t encountered any occurrences that requires such check.
Abseil-byte
pushed a commit
to Abseil-byte/angular
that referenced
this pull request
Nov 5, 2023
While `performance.mark` is available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker. This commit, updates the usage to a safer variant. PR Close angular#52505
Abseil-byte
pushed a commit
to Abseil-byte/angular
that referenced
this pull request
Nov 5, 2023
While `performance.mark` is available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker. PR Close angular#52505
4 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
While `performance.mark` is available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker. This commit, updates the usage to a safer variant. PR Close angular#52505
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
While `performance.mark` is available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker. PR Close angular#52505
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
While `performance.mark` is available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker. This commit, updates the usage to a safer variant. PR Close angular#52505
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
While `performance.mark` is available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker. PR Close angular#52505
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
performance.markis available on all supported browsers and node.js version this API is not available in JSDOM which is used by Jest and Cloudflare worker.This commit, updates the usage to a safer variant.