fix(migrations): Add support for ng-templates with i18n attributes #52597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicajaniuk
added
action: review
AndrewKushnir
approved these changes
Nov 7, 2023
packages/core/schematics/ng-generate/control-flow-migration/types.ts
Outdated
Show resolved
Hide resolved
jessicajaniuk
force-pushed
the
migration-i18n
branch
from
28f5f8d
to
15d29cb
Compare
This makes sure that i18n attributes are preserved on ng-templates being removed during the migration. fixes: angular#52517
jessicajaniuk
force-pushed
the
migration-i18n
branch
from
15d29cb
to
86662bd
Compare
jessicajaniuk
added
action: merge
|
caretaker note: g3 failures are flakes / unrelated. This is safe to merge. |
|
This PR was merged into the repository by commit 12f979d. |
atscott
pushed a commit
that referenced
this pull request
Nov 8, 2023
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…ngular#52597) This makes sure that i18n attributes are preserved on ng-templates being removed during the migration. fixes: angular#52517 PR Close angular#52597
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ngular#52597) This makes sure that i18n attributes are preserved on ng-templates being removed during the migration. fixes: angular#52517 PR Close angular#52597
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that i18n attributes are preserved on ng-templates being removed during the migration.
fixes: #52517
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?