Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-cli): add interpolatedSignalNotInvoked to diagnostics #52687

Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): add interpolatedSignalNotInvoked to diagnostics #52687

wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

This template diagnostic has been introduced in 8eef694 but was not enabled, as it was not added to ALL_DIAGNOSTIC_FACTORIES.

What is the new behavior?

Adds it to the available diagnostics

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@cexbrayat
fix(compiler-cli): add interpolatedSignalNotInvoked to diagnostics
efa746e 
This template diagnostic has been introduced in 8eef694 but was not enabled,
as it was not added to `ALL_DIAGNOSTIC_FACTORIES`.
@pullapprove pullapprove bot requested a review from alxhub November 8, 2023 16:36
@jessicajaniuk jessicajaniuk added the area: compiler Issues related to `ngc`, Angular's template compiler label Nov 8, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 8, 2023
JoostK
JoostK approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@JoostK JoostK removed the request for review from alxhub November 8, 2023 18:50
@JoostK JoostK added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 8, 2023
@jessicajaniuk jessicajaniuk added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 9, 2023
@jessicajaniuk
Copy link
Contributor

Caretaker note: g3 failures are unrelated. Safe to merge.

@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 8a87e62.

jessicajaniuk pushed a commit that referenced this pull request Nov 9, 2023
@cexbrayat @thePunderWoman
fix(compiler-cli): add interpolatedSignalNotInvoked to diagnostics (#…
7a95ccc 
…52687)

This template diagnostic has been introduced in 8eef694 but was not enabled,
as it was not added to `ALL_DIAGNOSTIC_FACTORIES`.

PR Close #52687
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
@cexbrayat @tbondwilkinson
fix(compiler-cli): add interpolatedSignalNotInvoked to diagnostics (a…
218c699 
…ngular#52687)

This template diagnostic has been introduced in 8eef694 but was not enabled,
as it was not added to `ALL_DIAGNOSTIC_FACTORIES`.

PR Close angular#52687
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@cexbrayat @ChellappanRajan
fix(compiler-cli): add interpolatedSignalNotInvoked to diagnostics (a…
a9c82b7 
…ngular#52687)

This template diagnostic has been introduced in 8eef694 but was not enabled,
as it was not added to `ALL_DIAGNOSTIC_FACTORIES`.

PR Close angular#52687
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cexbrayat @jessicajaniuk @JoostK