fix(compiler-cli): incorrect inferred type of for loop implicit variables #52732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bles Fixes that all implicit variables in `@for` loops were inferred to be numbers, even though most are actually boolean. Note that I also had to work around a weird TypeScript behavior in `tsDeclareVariable` where usually we declare variables in the following format: ``` var _t1: <type> = null!; ``` This works in most cases, but if the type is a `boolean`, TypeScript infers the variable as `never`, instead of `boolean`. I've worked around it by adding an `as boolean` to the initializer. Fixes angular#52730.
crisbeto
added
action: review
JoostK
approved these changes
Nov 9, 2023
JoostK
added
action: merge
|
This PR was merged into the repository by commit 645447d. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 9, 2023
…bles (#52732) Fixes that all implicit variables in `@for` loops were inferred to be numbers, even though most are actually boolean. Note that I also had to work around a weird TypeScript behavior in `tsDeclareVariable` where usually we declare variables in the following format: ``` var _t1: <type> = null!; ``` This works in most cases, but if the type is a `boolean`, TypeScript infers the variable as `never`, instead of `boolean`. I've worked around it by adding an `as boolean` to the initializer. Fixes #52730. PR Close #52732
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…bles (angular#52732) Fixes that all implicit variables in `@for` loops were inferred to be numbers, even though most are actually boolean. Note that I also had to work around a weird TypeScript behavior in `tsDeclareVariable` where usually we declare variables in the following format: ``` var _t1: <type> = null!; ``` This works in most cases, but if the type is a `boolean`, TypeScript infers the variable as `never`, instead of `boolean`. I've worked around it by adding an `as boolean` to the initializer. Fixes angular#52730. PR Close angular#52732
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…bles (angular#52732) Fixes that all implicit variables in `@for` loops were inferred to be numbers, even though most are actually boolean. Note that I also had to work around a weird TypeScript behavior in `tsDeclareVariable` where usually we declare variables in the following format: ``` var _t1: <type> = null!; ``` This works in most cases, but if the type is a `boolean`, TypeScript infers the variable as `never`, instead of `boolean`. I've worked around it by adding an `as boolean` to the initializer. Fixes angular#52730. PR Close angular#52732
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that all implicit variables in
@forloops were inferred to be numbers, even though most are actually boolean.Note that I also had to work around a weird TypeScript behavior in
tsDeclareVariablewhere usually we declare variables in the following format:This works in most cases, but if the type is a
boolean, TypeScript infers the variable asnever, instead ofboolean. I've worked around it by adding anas booleanto the initializer.Fixes #52730.