Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): limit rate of markers invocations #52742

Closed
wants to merge 1 commit into from
Closed

fix(core): limit rate of markers invocations #52742

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

This PR assures that the performance markers are invoked only once for a given feature.

Closes #52524

@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Nov 9, 2023
@ngbot ngbot bot modified the milestone: Backlog Nov 9, 2023
alxhub
alxhub approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing symbol tests will need to be updated but LGTM otherwise

@pkozlowski-opensource
fix(core): limit rate of markers invocations
2415052 
This PR assures that the performance markers are invoked
only once for a given feature.

Closes angular#52524
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 9, 2023
@ngbot
Copy link

ngbot bot commented Nov 9, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending forbidden labels detected: action: review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 6c8776f.

jessicajaniuk pushed a commit that referenced this pull request Nov 9, 2023
@pkozlowski-opensource @thePunderWoman
fix(core): limit rate of markers invocations (#52742)
b16fc26 
This PR assures that the performance markers are invoked
only once for a given feature.

Closes #52524

PR Close #52742
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Nov 10, 2023
Closed
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
@pkozlowski-opensource @tbondwilkinson
fix(core): limit rate of markers invocations (angular#52742)
34a20d8 
This PR assures that the performance markers are invoked
only once for a given feature.

Closes angular#52524

PR Close angular#52742
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@pkozlowski-opensource @ChellappanRajan
fix(core): limit rate of markers invocations (angular#52742)
4c77354 
This PR assures that the performance markers are invoked
only once for a given feature.

Closes angular#52524

PR Close angular#52742
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

For loops in new control flow are extremely slow and taking much more memory than ngFor
3 participants
@pkozlowski-opensource @jessicajaniuk @alxhub