Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(migrations): Fixes issue with multiple if elses with same template #52863

Closed
wants to merge 1 commit into from
Closed

fix(migrations): Fixes issue with multiple if elses with same template #52863

wants to merge 1 commit into from

Conversation

jessicajaniuk
Copy link
Contributor

This should fix the issue where if the same ng-template is used with multiple if / else statements, it replaces all usages properly.

fixes: #52854

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk
fix(migrations): Fixes issue with multiple if elses with same template
aa7ccb0 
This should fix the issue where if the same ng-template is used with multiple if / else statements, it replaces all usages properly.
fixes: angular#52854
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update` migrations labels Nov 13, 2023
@ngbot ngbot bot modified the milestone: Backlog Nov 13, 2023
@jessicajaniuk jessicajaniuk mentioned this pull request Nov 13, 2023
Closed
crisbeto
crisbeto approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicajaniuk jessicajaniuk removed the request for review from AndrewKushnir November 13, 2023 18:19
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 13, 2023
@jessicajaniuk
Copy link
Contributor Author

This PR was merged into the repository by commit 0e7b1da.

jessicajaniuk added a commit that referenced this pull request Nov 13, 2023
@jessicajaniuk
fix(migrations): Fixes issue with multiple if elses with same template (
3831942 
#52863)

This should fix the issue where if the same ng-template is used with multiple if / else statements, it replaces all usages properly.
fixes: #52854

PR Close #52863
@jessicajaniuk jessicajaniuk deleted the migrate-fix branch November 13, 2023 18:27
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
@jessicajaniuk @tbondwilkinson
fix(migrations): Fixes issue with multiple if elses with same template (
d420d8a 
angular#52863)

This should fix the issue where if the same ng-template is used with multiple if / else statements, it replaces all usages properly.
fixes: angular#52854

PR Close angular#52863
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@jessicajaniuk @ChellappanRajan
fix(migrations): Fixes issue with multiple if elses with same template (
5396b88 
angular#52863)

This should fix the issue where if the same ng-template is used with multiple if / else statements, it replaces all usages properly.
fixes: angular#52854

PR Close angular#52863
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@jessicajaniuk @rlmestre
fix(migrations): Fixes issue with multiple if elses with same template (
2be3733 
angular#52863)

This should fix the issue where if the same ng-template is used with multiple if / else statements, it replaces all usages properly.
fixes: angular#52854

PR Close angular#52863
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@jessicajaniuk @amilamen
fix(migrations): Fixes issue with multiple if elses with same template (
66962df 
angular#52863)

This should fix the issue where if the same ng-template is used with multiple if / else statements, it replaces all usages properly.
fixes: angular#52854

PR Close angular#52863
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Control flow - template used in multiple else clauses
2 participants
@jessicajaniuk @crisbeto