New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): inconsistent router state, missing execution of data resolvers #52934
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@leonelvsc I already had a fix for this but hadn't gotten a change to open the PR yet. I wanted to give you credit for the investigations you did so just amended your PR with the changes and required test. |
Thanks! |
… able to execute together The following commit accidentally broken execution of resolvers when two resolvers appear in different parts of the tree and do not share a angular@3278966 This happens when there are secondary routes. This test ensures that all routes with resolves are run. fixes angular#52892
This PR was merged into the repository by commit 29e0834. |
… able to execute together (#52934) The following commit accidentally broken execution of resolvers when two resolvers appear in different parts of the tree and do not share a 3278966 This happens when there are secondary routes. This test ensures that all routes with resolves are run. fixes #52892 PR Close #52934
… able to execute together (angular#52934) The following commit accidentally broken execution of resolvers when two resolvers appear in different parts of the tree and do not share a angular@3278966 This happens when there are secondary routes. This test ensures that all routes with resolves are run. fixes angular#52892 PR Close angular#52934
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
… able to execute together (angular#52934) The following commit accidentally broken execution of resolvers when two resolvers appear in different parts of the tree and do not share a angular@3278966 This happens when there are secondary routes. This test ensures that all routes with resolves are run. fixes angular#52892 PR Close angular#52934
… able to execute together (angular#52934) The following commit accidentally broken execution of resolvers when two resolvers appear in different parts of the tree and do not share a angular@3278966 This happens when there are secondary routes. This test ensures that all routes with resolves are run. fixes angular#52892 PR Close angular#52934
… able to execute together (angular#52934) The following commit accidentally broken execution of resolvers when two resolvers appear in different parts of the tree and do not share a angular@3278966 This happens when there are secondary routes. This test ensures that all routes with resolves are run. fixes angular#52892 PR Close angular#52934
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #52892
What is the new behavior?
All the route resolvers should run
Does this PR introduce a breaking change?
Other information
Just edited the source code, tested modifying source code of "router.mjs" from the project showed in the issue.