Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): inconsistent router state, missing execution of data resolvers #52934

Closed
wants to merge 1 commit into from

Conversation

leonelvsc
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • [X ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #52892

What is the new behavior?

All the route resolvers should run

Does this PR introduce a breaking change?

  • Yes
  • [ X] No

Other information

Just edited the source code, tested modifying source code of "router.mjs" from the project showed in the issue.

Copy link

google-cla bot commented Nov 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@atscott
Copy link
Contributor

atscott commented Nov 15, 2023

@leonelvsc I already had a fix for this but hadn't gotten a change to open the PR yet. I wanted to give you credit for the investigations you did so just amended your PR with the changes and required test.

@leonelvsc
Copy link
Contributor Author

@leonelvsc I already had a fix for this but hadn't gotten a change to open the PR yet. I wanted to give you credit for the investigations you did so just amended your PR with the changes and required test.

Thanks!

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer area: router target: patch This PR is targeted for the next patch release labels Nov 15, 2023
@ngbot ngbot bot modified the milestone: Backlog Nov 15, 2023
… able to execute together

The following commit accidentally broken execution of resolvers when
two resolvers appear in different parts of the tree and do not share a
angular@3278966

This happens when there are secondary routes. This test ensures that all
routes with resolves are run.

fixes angular#52892
@leonelvsc leonelvsc changed the title Fix #52892 inconsistent router state, missing execution of data resolvers fix(router): inconsistent router state, missing execution of data resolvers Nov 16, 2023
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 17, 2023
@jessicajaniuk jessicajaniuk removed the request for review from AndrewKushnir November 20, 2023 18:28
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 29e0834.

AndrewKushnir pushed a commit that referenced this pull request Nov 20, 2023
… able to execute together (#52934)

The following commit accidentally broken execution of resolvers when
two resolvers appear in different parts of the tree and do not share a
3278966

This happens when there are secondary routes. This test ensures that all
routes with resolves are run.

fixes #52892

PR Close #52934
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
… able to execute together (angular#52934)

The following commit accidentally broken execution of resolvers when
two resolvers appear in different parts of the tree and do not share a
angular@3278966

This happens when there are secondary routes. This test ensures that all
routes with resolves are run.

fixes angular#52892

PR Close angular#52934
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 21, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
… able to execute together (angular#52934)

The following commit accidentally broken execution of resolvers when
two resolvers appear in different parts of the tree and do not share a
angular@3278966

This happens when there are secondary routes. This test ensures that all
routes with resolves are run.

fixes angular#52892

PR Close angular#52934
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
… able to execute together (angular#52934)

The following commit accidentally broken execution of resolvers when
two resolvers appear in different parts of the tree and do not share a
angular@3278966

This happens when there are secondary routes. This test ensures that all
routes with resolves are run.

fixes angular#52892

PR Close angular#52934
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
… able to execute together (angular#52934)

The following commit accidentally broken execution of resolvers when
two resolvers appear in different parts of the tree and do not share a
angular@3278966

This happens when there are secondary routes. This test ensures that all
routes with resolves are run.

fixes angular#52892

PR Close angular#52934
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants