fix(compiler): changed after checked error in for loops #52935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
force-pushed
the
52885/for-changed-after-checked
branch
from
ed8355f
to
7f916aa
Compare
Reworks the `repeater` instruction to go through `advance`, instead of passing in the index directly. This ensures that lifecycle hooks run at the right time and that we don't throw "changed after checked" errors when we shouldn't be. Fixes angular#52885.
crisbeto
force-pushed
the
52885/for-changed-after-checked
branch
from
7f916aa
to
f585011
Compare
pkozlowski-opensource
approved these changes
Nov 15, 2023
crisbeto
added
action: merge
|
Caretaker note: there are a handful of failing targets in the presubmit, but they're all in one app that isn't using the new control flow at all and they appear to be unrelated. |
|
This PR was merged into the repository by commit ec2d6e7. |
dylhunn
reviewed
Nov 16, 2023
1 task
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
Reworks the `repeater` instruction to go through `advance`, instead of passing in the index directly. This ensures that lifecycle hooks run at the right time and that we don't throw "changed after checked" errors when we shouldn't be. Fixes angular#52885. PR Close angular#52935
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Reworks the `repeater` instruction to go through `advance`, instead of passing in the index directly. This ensures that lifecycle hooks run at the right time and that we don't throw "changed after checked" errors when we shouldn't be. Fixes angular#52885. PR Close angular#52935
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
Reworks the `repeater` instruction to go through `advance`, instead of passing in the index directly. This ensures that lifecycle hooks run at the right time and that we don't throw "changed after checked" errors when we shouldn't be. Fixes angular#52885. PR Close angular#52935
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
Reworks the `repeater` instruction to go through `advance`, instead of passing in the index directly. This ensures that lifecycle hooks run at the right time and that we don't throw "changed after checked" errors when we shouldn't be. Fixes angular#52885. PR Close angular#52935
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the
repeaterinstruction to go throughadvance, instead of passing in the index directly. This ensures that lifecycle hooks run at the right time and that we don't throw "changed after checked" errors when we shouldn't be.Fixes #52885.