Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): scan images once page is loaded #52991

Closed
wants to merge 1 commit into from
Closed

fix(common): scan images once page is loaded #52991

wants to merge 1 commit into from

Conversation

arturovt
Copy link
Contributor

This commit updates the implementation of the ImagePerformanceWarning and runs the image scan even if the page has already been loaded. The window.load event would never fire if the page has already been loaded; that's why we're checking for the document's ready state.

@arturovt
fix(common): scan images once page is loaded
6888bba 
This commit updates the implementation of the `ImagePerformanceWarning` and
runs the image scan even if the page has already been loaded. The `window.load`
event would never fire if the page has already been loaded; that's why we're
checking for the document's ready state.
@AndrewKushnir
Copy link
Contributor

// cc @atcastle

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package common: image directive labels Nov 17, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 17, 2023
@AndrewKushnir AndrewKushnir added the target: patch This PR is targeted for the next patch release label Nov 17, 2023
atcastle
atcastle approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@atcastle atcastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/core/src/image_performance_warning.ts Show resolved Hide resolved
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 17, 2023
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 7affa57.

AndrewKushnir pushed a commit that referenced this pull request Nov 20, 2023
@arturovt @AndrewKushnir
fix(common): scan images once page is loaded (#52991)
fafcb0d 
This commit updates the implementation of the `ImagePerformanceWarning` and
runs the image scan even if the page has already been loaded. The `window.load`
event would never fire if the page has already been loaded; that's why we're
checking for the document's ready state.

PR Close #52991
@arturovt arturovt deleted the fix/perf-warning-load-listener branch November 20, 2023 17:04
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
@arturovt @tbondwilkinson
fix(common): scan images once page is loaded (angular#52991)
30920b2 
This commit updates the implementation of the `ImagePerformanceWarning` and
runs the image scan even if the page has already been loaded. The `window.load`
event would never fire if the page has already been loaded; that's why we're
checking for the document's ready state.

PR Close angular#52991
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 21, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@arturovt @ChellappanRajan
fix(common): scan images once page is loaded (angular#52991)
bdfea32 
This commit updates the implementation of the `ImagePerformanceWarning` and
runs the image scan even if the page has already been loaded. The `window.load`
event would never fire if the page has already been loaded; that's why we're
checking for the document's ready state.

PR Close angular#52991
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@arturovt @rlmestre
fix(common): scan images once page is loaded (angular#52991)
a35bc6c 
This commit updates the implementation of the `ImagePerformanceWarning` and
runs the image scan even if the page has already been loaded. The `window.load`
event would never fire if the page has already been loaded; that's why we're
checking for the document's ready state.

PR Close angular#52991
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@arturovt @amilamen
fix(common): scan images once page is loaded (angular#52991)
6d07c2a 
This commit updates the implementation of the `ImagePerformanceWarning` and
runs the image scan even if the page has already been loaded. The `window.load`
event would never fire if the page has already been loaded; that's why we're
checking for the document's ready state.

PR Close angular#52991
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atcastle atcastle atcastle approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package common: image directive target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arturovt @AndrewKushnir @atcastle