Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): tweaks to formatting in control flow migration #53058

Closed
wants to merge 1 commit into from

Conversation

jessicajaniuk
Copy link
Contributor

This addresses a few minor formatting issues with the control flow migration.

fixes: #53017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update` migrations labels Nov 20, 2023
@ngbot ngbot bot modified the milestone: Backlog Nov 20, 2023
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 20, 2023
@jessicajaniuk jessicajaniuk added the action: merge The PR is ready for merge by the caretaker label Nov 20, 2023
This addresses a few minor formatting issues with the control flow migration.

fixes: angular#53017
@jessicajaniuk jessicajaniuk added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 20, 2023
@jessicajaniuk
Copy link
Contributor Author

caretaker note: This is safe to merge. Failing g3 tests are unrelated.

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit e090b48.

AndrewKushnir pushed a commit that referenced this pull request Nov 20, 2023
This addresses a few minor formatting issues with the control flow migration.

fixes: #53017

PR Close #53058
@jessicajaniuk jessicajaniuk deleted the migration-formats branch November 28, 2023 17:09
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
…lar#53058)

This addresses a few minor formatting issues with the control flow migration.

fixes: angular#53017

PR Close angular#53058
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…lar#53058)

This addresses a few minor formatting issues with the control flow migration.

fixes: angular#53017

PR Close angular#53058
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
…lar#53058)

This addresses a few minor formatting issues with the control flow migration.

fixes: angular#53017

PR Close angular#53058
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
…lar#53058)

This addresses a few minor formatting issues with the control flow migration.

fixes: angular#53017

PR Close angular#53058
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control Flow Migration: Formatting issues
3 participants