fix(migrations): cf migration fix migrating empty switch default #53237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicajaniuk
added
action: review
This was referenced Nov 28, 2023
crisbeto
approved these changes
Nov 29, 2023
pkozlowski-opensource
added
action: cleanup
|
@jessicajaniuk this one will need rebase before we can merge it |
This should address cases when using ng-containers with ngSwitchCase / ngSwitchDefault and migrating them safely when they are empty. fixes: angular#53235
jessicajaniuk
force-pushed
the
migration-switchfix
branch
from
360dd68
to
ae06e39
Compare
jessicajaniuk
added
action: merge
|
This PR was merged into the repository by commit fadfee4. |
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…ular#53237) This should address cases when using ng-containers with ngSwitchCase / ngSwitchDefault and migrating them safely when they are empty. fixes: angular#53235 PR Close angular#53237
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ular#53237) This should address cases when using ng-containers with ngSwitchCase / ngSwitchDefault and migrating them safely when they are empty. fixes: angular#53235 PR Close angular#53237
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…ular#53237) This should address cases when using ng-containers with ngSwitchCase / ngSwitchDefault and migrating them safely when they are empty. fixes: angular#53235 PR Close angular#53237
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…ular#53237) This should address cases when using ng-containers with ngSwitchCase / ngSwitchDefault and migrating them safely when they are empty. fixes: angular#53235 PR Close angular#53237
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address cases when using ng-containers with ngSwitchCase / ngSwitchDefault
and migrating them safely when they are empty.
fixes: #53235
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information