Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): CF migration log warning when collection aliasing detected in @for #53238

Closed
wants to merge 1 commit into from

Conversation

jessicajaniuk
Copy link
Contributor

This logs a warning when an ngFor has a collection aliased, which is not supported with new syntax.

fixes: #53233

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update` migrations labels Nov 28, 2023
@ngbot ngbot bot modified the milestone: Backlog Nov 28, 2023
…tected in @for

This logs a warning when an ngFor has a collection aliased, which is not supported with new syntax.

fixes: angular#53233
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 28, 2023
@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Nov 29, 2023
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit b2aeaf5.

pkozlowski-opensource pushed a commit that referenced this pull request Nov 29, 2023
…tected in @for (#53238)

This logs a warning when an ngFor has a collection aliased, which is not supported with new syntax.

fixes: #53233

PR Close #53238
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
…tected in @for (angular#53238)

This logs a warning when an ngFor has a collection aliased, which is not supported with new syntax.

fixes: angular#53233

PR Close angular#53238
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 30, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…tected in @for (angular#53238)

This logs a warning when an ngFor has a collection aliased, which is not supported with new syntax.

fixes: angular#53233

PR Close angular#53238
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
…tected in @for (angular#53238)

This logs a warning when an ngFor has a collection aliased, which is not supported with new syntax.

fixes: angular#53233

PR Close angular#53238
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
…tected in @for (angular#53238)

This logs a warning when an ngFor has a collection aliased, which is not supported with new syntax.

fixes: angular#53233

PR Close angular#53238
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control flow schematic: ngFor + as syntax produces invalid code
4 participants