fix(migrations): fix off by one issue with template removal in CF migration #53255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration When ng-templates are removed, an extra space was being added when it was unnecessary. This resulted in malformed html if there was no space afterwards. fixes: angular#53248
jessicajaniuk
added
action: review
crisbeto
approved these changes
Nov 29, 2023
jessicajaniuk
added
action: merge
|
This PR was merged into the repository by commit 6291c8d. |
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…ration (angular#53255) When ng-templates are removed, an extra space was being added when it was unnecessary. This resulted in malformed html if there was no space afterwards. fixes: angular#53248 PR Close angular#53255
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ration (angular#53255) When ng-templates are removed, an extra space was being added when it was unnecessary. This resulted in malformed html if there was no space afterwards. fixes: angular#53248 PR Close angular#53255
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…ration (angular#53255) When ng-templates are removed, an extra space was being added when it was unnecessary. This resulted in malformed html if there was no space afterwards. fixes: angular#53248 PR Close angular#53255
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…ration (angular#53255) When ng-templates are removed, an extra space was being added when it was unnecessary. This resulted in malformed html if there was no space afterwards. fixes: angular#53248 PR Close angular#53255
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ng-templates are removed, an extra space was being added when it was unnecessary. This resulted in malformed html if there was no space afterwards.
fixes: #53248
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?