New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): support hydration for cases when content is re-projected using ng-template #53304
fix(core): support hydration for cases when content is re-projected using ng-template #53304
Conversation
…sing ng-template This commit fixes an issue with hydration, which happens when a content is projected in a certain way, leaving host elements non-projected, but the child content projected. The fix is to detect such situations and add extra annotations to help runtime logic locate those elements at the right locations. Resolves angular#53276.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
This PR was merged into the repository by commit 4b23221. |
…sing ng-template (#53304) This commit fixes an issue with hydration, which happens when a content is projected in a certain way, leaving host elements non-projected, but the child content projected. The fix is to detect such situations and add extra annotations to help runtime logic locate those elements at the right locations. Resolves #53276. PR Close #53304
…sing ng-template (angular#53304) This commit fixes an issue with hydration, which happens when a content is projected in a certain way, leaving host elements non-projected, but the child content projected. The fix is to detect such situations and add extra annotations to help runtime logic locate those elements at the right locations. Resolves angular#53276. PR Close angular#53304
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…sing ng-template (angular#53304) This commit fixes an issue with hydration, which happens when a content is projected in a certain way, leaving host elements non-projected, but the child content projected. The fix is to detect such situations and add extra annotations to help runtime logic locate those elements at the right locations. Resolves angular#53276. PR Close angular#53304
…sing ng-template (angular#53304) This commit fixes an issue with hydration, which happens when a content is projected in a certain way, leaving host elements non-projected, but the child content projected. The fix is to detect such situations and add extra annotations to help runtime logic locate those elements at the right locations. Resolves angular#53276. PR Close angular#53304
…sing ng-template (angular#53304) This commit fixes an issue with hydration, which happens when a content is projected in a certain way, leaving host elements non-projected, but the child content projected. The fix is to detect such situations and add extra annotations to help runtime logic locate those elements at the right locations. Resolves angular#53276. PR Close angular#53304
This commit fixes an issue with hydration, which happens when a content is projected in a certain way, leaving host elements non-projected, but the child content projected.
The fix is to detect such situations and add extra annotations to help runtime logic locate those elements at the right locations.
Resolves #53276.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?