fix(migrations): CF Migration - ensure bound ngIfElse cases ignore line breaks #53435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne breaks When using ternaries or other expressions in bound if / else cases, it is possible that line breaks could end up affecting template replacement. fixes: angular#53428
jessicajaniuk
added
action: review
crisbeto
approved these changes
Dec 8, 2023
pkozlowski-opensource
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
pkozlowski-opensource
added
the
merge: caretaker note
|
caretaker note: G3 failures are unrelated |
jessicajaniuk
removed
the
merge: caretaker note
|
This PR was merged into the repository by commit a027679. |
josephperrott
pushed a commit
to josephperrott/angular
that referenced
this pull request
Dec 11, 2023
…ne breaks (angular#53435) When using ternaries or other expressions in bound if / else cases, it is possible that line breaks could end up affecting template replacement. fixes: angular#53428 PR Close angular#53435
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ne breaks (angular#53435) When using ternaries or other expressions in bound if / else cases, it is possible that line breaks could end up affecting template replacement. fixes: angular#53428 PR Close angular#53435
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…ne breaks (angular#53435) When using ternaries or other expressions in bound if / else cases, it is possible that line breaks could end up affecting template replacement. fixes: angular#53428 PR Close angular#53435
danieljancar
pushed a commit
to danieljancar/angular
that referenced
this pull request
Jan 26, 2024
…ne breaks (angular#53435) When using ternaries or other expressions in bound if / else cases, it is possible that line breaks could end up affecting template replacement. fixes: angular#53428 PR Close angular#53435
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…ne breaks (angular#53435) When using ternaries or other expressions in bound if / else cases, it is possible that line breaks could end up affecting template replacement. fixes: angular#53428 PR Close angular#53435
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ternaries or other expressions in bound if / else cases, it is possible that line breaks could end up affecting template replacement.
fixes: #53428
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?