Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(core): avoid changes Observable creation on QueryList #53498

Closed
wants to merge 1 commit into from
Closed

perf(core): avoid changes Observable creation on QueryList #53498

wants to merge 1 commit into from

Commits on Dec 11, 2023

  1. perf(core): avoid changes Observable creation on QueryList 

    The changes Observable (impl: EventEmitter) on the QueryList is initalized
lazy - it is created only if someone calls a geter to get a hand on its
instance. But the destroy method was calling this getter thus creating
a new Observable even if no one subscribed to it.

This commit changes the destroy logic to skip creation of an EventEmitter
if it wasn't initialized.
    @pkozlowski-opensource
    pkozlowski-opensource committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    2271332 View commit details
    Browse the repository at this point in the history