fix(router): provide more actionable error message when route is not matched in production mode #53523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
error-route-not-found
branch
from
5dbb106
to
c3fe3ec
Compare
…matched in production mode Prior to this commit when a route is not matched and the application was running in production mode an `[Error]: NG04002` was logged in the console. This however, is not actionable when the application is running on the server where there can be multiple pages being rendered at the same time. Now we change this to also log the route example: `[Error]: NG04002: 'products/Jeep'`. Closes angular#53522
alan-agius4
force-pushed
the
error-route-not-found
branch
from
c3fe3ec
to
c5fa9fd
Compare
alan-agius4
commented
Dec 12, 2023
| @@ -58,13 +58,6 @@ export function canLoadFails(route: Route): Observable<LoadedRouterConfig> { | |||
| export class ApplyRedirects { | |||
| constructor(private urlSerializer: UrlSerializer, private urlTree: UrlTree) {} | |||
|
|
|||
| noMatchError(e: NoMatch): any { | |||
There was a problem hiding this comment.
This was unused.
AndrewKushnir
approved these changes
Dec 12, 2023
AndrewKushnir
removed
the
action: review
|
This PR was merged into the repository by commit 48c5041. |
alxhub
pushed a commit
that referenced
this pull request
Dec 12, 2023
…matched in production mode (#53523) Prior to this commit when a route is not matched and the application was running in production mode an `[Error]: NG04002` was logged in the console. This however, is not actionable when the application is running on the server where there can be multiple pages being rendered at the same time. Now we change this to also log the route example: `[Error]: NG04002: 'products/Jeep'`. Closes #53522 PR Close #53523
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…matched in production mode (angular#53523) Prior to this commit when a route is not matched and the application was running in production mode an `[Error]: NG04002` was logged in the console. This however, is not actionable when the application is running on the server where there can be multiple pages being rendered at the same time. Now we change this to also log the route example: `[Error]: NG04002: 'products/Jeep'`. Closes angular#53522 PR Close angular#53523
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…matched in production mode (angular#53523) Prior to this commit when a route is not matched and the application was running in production mode an `[Error]: NG04002` was logged in the console. This however, is not actionable when the application is running on the server where there can be multiple pages being rendered at the same time. Now we change this to also log the route example: `[Error]: NG04002: 'products/Jeep'`. Closes angular#53522 PR Close angular#53523
danieljancar
pushed a commit
to danieljancar/angular
that referenced
this pull request
Jan 26, 2024
…matched in production mode (angular#53523) Prior to this commit when a route is not matched and the application was running in production mode an `[Error]: NG04002` was logged in the console. This however, is not actionable when the application is running on the server where there can be multiple pages being rendered at the same time. Now we change this to also log the route example: `[Error]: NG04002: 'products/Jeep'`. Closes angular#53522 PR Close angular#53523
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…matched in production mode (angular#53523) Prior to this commit when a route is not matched and the application was running in production mode an `[Error]: NG04002` was logged in the console. This however, is not actionable when the application is running on the server where there can be multiple pages being rendered at the same time. Now we change this to also log the route example: `[Error]: NG04002: 'products/Jeep'`. Closes angular#53522 PR Close angular#53523
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit when a route is not matched and the application was running in production mode an
[Error]: NG04002was logged in the console. This however, is not actionable when the application is running on the server where there can be multiple pages being rendered at the same time.Now we change this to also log the route example:
[Error]: NG04002: 'products/Jeep'.Closes #53522