-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zoneless scheduler to the ApplicationRef.isStable indicator #53579
Conversation
fe5326e
to
a7c4469
Compare
a7c4469
to
df515b4
Compare
df515b4
to
a01dd83
Compare
a01dd83
to
16ec80c
Compare
Hi provideChangeDetection(withZone()); The only issue with that is that a required migration would be needed to migrate every app to use it. And then have it removed for default zoneless change detection. |
Then probably the default could be zonefull, and the api could be |
Yeah that's the point, because the default would be without zone, it wouldn't be necessary to write it at all. |
We already have the edit - Excerpt from the design doc:
|
This commit updates the test scheduler implementation to contribute to ApplicationRef stableness.
This commit moves the implementation of the change detection scheduler used for testing to angular/core along with a (private export) provider function. Note: Naming of the provider function is absolutely not final (and not public API). I would prefer one that did not mention "zones" but the easiest thing for now is to have a "Zone" and "Zoneless" naming scheme.
16ec80c
to
a354f03
Compare
#53579) This commit moves the implementation of the change detection scheduler used for testing to angular/core along with a (private export) provider function. Note: Naming of the provider function is absolutely not final (and not public API). I would prefer one that did not mention "zones" but the easiest thing for now is to have a "Zone" and "Zoneless" naming scheme. PR Close #53579
This PR was merged into the repository by commit 5978b3d. |
#53579) This commit moves the implementation of the change detection scheduler used for testing to angular/core along with a (private export) provider function. Note: Naming of the provider function is absolutely not final (and not public API). I would prefer one that did not mention "zones" but the easiest thing for now is to have a "Zone" and "Zoneless" naming scheme. PR Close #53579
…le` (angular#53579) This commit updates the test scheduler implementation to contribute to ApplicationRef stableness. PR Close angular#53579
angular#53579) This commit moves the implementation of the change detection scheduler used for testing to angular/core along with a (private export) provider function. Note: Naming of the provider function is absolutely not final (and not public API). I would prefer one that did not mention "zones" but the easiest thing for now is to have a "Zone" and "Zoneless" naming scheme. PR Close angular#53579
…le` (angular#53579) This commit updates the test scheduler implementation to contribute to ApplicationRef stableness. PR Close angular#53579
angular#53579) This commit moves the implementation of the change detection scheduler used for testing to angular/core along with a (private export) provider function. Note: Naming of the provider function is absolutely not final (and not public API). I would prefer one that did not mention "zones" but the easiest thing for now is to have a "Zone" and "Zoneless" naming scheme. PR Close angular#53579
…le` (angular#53579) This commit updates the test scheduler implementation to contribute to ApplicationRef stableness. PR Close angular#53579
angular#53579) This commit moves the implementation of the change detection scheduler used for testing to angular/core along with a (private export) provider function. Note: Naming of the provider function is absolutely not final (and not public API). I would prefer one that did not mention "zones" but the easiest thing for now is to have a "Zone" and "Zoneless" naming scheme. PR Close angular#53579
…le` (angular#53579) This commit updates the test scheduler implementation to contribute to ApplicationRef stableness. PR Close angular#53579
angular#53579) This commit moves the implementation of the change detection scheduler used for testing to angular/core along with a (private export) provider function. Note: Naming of the provider function is absolutely not final (and not public API). I would prefer one that did not mention "zones" but the easiest thing for now is to have a "Zone" and "Zoneless" naming scheme. PR Close angular#53579
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Commit 1:
test(core): Add scheduler in tests to tie into ApplicationRef.isStable
This commit updates the test scheduler implementation to contribute to
ApplicationRef stableness.
Commit 2
refactor(core): Move change detection scheduler implementation to core
This commit moves the implementation of the change detection scheduler
used for testing to angular/core along with a (private export) provider function.
Note: Naming of the provider function is absolutely not final (and not
public API). I would prefer one that did not mention "zones"
but the easiest thing for now is to have a "Zone" and "Zoneless" naming
scheme.