Support namespaced attributes in template pipeline #53646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
target: patch
dylhunn
approved these changes
Dec 19, 2023
...es/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/elements/namespace_attr.ts
Outdated
Show resolved
Hide resolved
...es/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/elements/namespace_attr.js
Outdated
Show resolved
Hide resolved
dylhunn
approved these changes
Dec 20, 2023
We currently do not support the `namespace` argument for the attribute instruction. (Who knew it even existed!)
mmalerba
added
action: merge
|
Caretaker Note: No g3 impact |
|
@mmalerba looks like you actually may need a golden update |
dylhunn
removed
action: merge
It's possible for attributes to have a namespace, we need to handle this possiblity for both attribute instructions and attributes extracted to the consts array.
|
updated |
mmalerba
added
action: merge
dylhunn
approved these changes
Dec 20, 2023
|
This PR was merged into the repository by commit 3302425. |
atscott
pushed a commit
that referenced
this pull request
Jan 3, 2024
We currently do not support the `namespace` argument for the attribute instruction. (Who knew it even existed!) PR Close #53646
atscott
pushed a commit
that referenced
this pull request
Jan 3, 2024
It's possible for attributes to have a namespace, we need to handle this possiblity for both attribute instructions and attributes extracted to the consts array. PR Close #53646
atscott
pushed a commit
that referenced
this pull request
Jan 3, 2024
It's possible for attributes to have a namespace, we need to handle this possiblity for both attribute instructions and attributes extracted to the consts array. PR Close #53646
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
We currently do not support the `namespace` argument for the attribute instruction. (Who knew it even existed!) PR Close angular#53646
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
) It's possible for attributes to have a namespace, we need to handle this possiblity for both attribute instructions and attributes extracted to the consts array. PR Close angular#53646
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
We currently do not support the `namespace` argument for the attribute instruction. (Who knew it even existed!) PR Close angular#53646
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
) It's possible for attributes to have a namespace, we need to handle this possiblity for both attribute instructions and attributes extracted to the consts array. PR Close angular#53646
danieljancar
pushed a commit
to danieljancar/angular
that referenced
this pull request
Jan 26, 2024
We currently do not support the `namespace` argument for the attribute instruction. (Who knew it even existed!) PR Close angular#53646
danieljancar
pushed a commit
to danieljancar/angular
that referenced
this pull request
Jan 26, 2024
) It's possible for attributes to have a namespace, we need to handle this possiblity for both attribute instructions and attributes extracted to the consts array. PR Close angular#53646
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
We currently do not support the `namespace` argument for the attribute instruction. (Who knew it even existed!) PR Close angular#53646
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
) It's possible for attributes to have a namespace, we need to handle this possiblity for both attribute instructions and attributes extracted to the consts array. PR Close angular#53646
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.