fix(compiler-cli): handle default imports in defer blocks #53695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
commented
Dec 25, 2023
| return ts.isImportSpecifier(node) ? node.parent!.parent!.parent! : | ||
| ts.isNamespaceImport(node) ? node.parent.parent : | ||
| null; | ||
| let parent = node.parent; |
There was a problem hiding this comment.
I could've special-cased default imports here like we had it before, but I think that this is a bit more robust.
AndrewKushnir
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Looks great, thanks for the fix 👍
As discussed offline, we are marking this PR as blocked for now to land PR #53591, which refactors/moves those parts of the logic, so it'd be harder to rebase.
AndrewKushnir
added
state: blocked
and removed
action: review
crisbeto
force-pushed
the
defer-default-import
branch
from
11a2ebb
to
1da4f7c
Compare
crisbeto
added
action: review
|
These changes should be unblocked now. |
AndrewKushnir
approved these changes
Jan 31, 2024
packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts
Outdated
Show resolved
Hide resolved
Fixes that `@defer` blocks weren't recognizing default imports and generating the proper code for them. Default symbols need to be accessed through the `default` property in the `import` statement, rather than by their name.
crisbeto
force-pushed
the
defer-default-import
branch
from
1da4f7c
to
b0d55b2
Compare
crisbeto
added
action: merge
jessicajaniuk
pushed a commit
that referenced
this pull request
Feb 1, 2024
Fixes that `@defer` blocks weren't recognizing default imports and generating the proper code for them. Default symbols need to be accessed through the `default` property in the `import` statement, rather than by their name. PR Close #53695
|
This PR was merged into the repository by commit 95dcf5f. |
JoostK
added a commit
to JoostK/angular
that referenced
this pull request
Feb 18, 2024
…ls in defer blocks This commit addresses a problem with PR angular#53695 that introduced support for default imports, where the actual dynamic import used in the defer loading function continued to use the symbol name, instead of `.default` for the dynamic import. This issue went unnoticed in the testcase because a proper instance was being generated for the `ɵsetClassMetadataAsync` function, but not the generated dependency loader function. Fixes angular#54491
JoostK
added a commit
to JoostK/angular
that referenced
this pull request
Feb 18, 2024
…ls in defer blocks This commit addresses a problem with PR angular#53695 that introduced support for default imports, where the actual dynamic import used in the defer loading function continued to use the symbol name, instead of `.default` for the dynamic import. This issue went unnoticed in the testcase because a proper instance was being generated for the `ɵsetClassMetadataAsync` function, but not the generated dependency loader function. Fixes angular#54491
alxhub
pushed a commit
that referenced
this pull request
Feb 20, 2024
…ls in defer blocks (#54495) This commit addresses a problem with PR #53695 that introduced support for default imports, where the actual dynamic import used in the defer loading function continued to use the symbol name, instead of `.default` for the dynamic import. This issue went unnoticed in the testcase because a proper instance was being generated for the `ɵsetClassMetadataAsync` function, but not the generated dependency loader function. Fixes #54491 PR Close #54495
alxhub
pushed a commit
that referenced
this pull request
Feb 20, 2024
…ls in defer blocks (#54495) This commit addresses a problem with PR #53695 that introduced support for default imports, where the actual dynamic import used in the defer loading function continued to use the symbol name, instead of `.default` for the dynamic import. This issue went unnoticed in the testcase because a proper instance was being generated for the `ɵsetClassMetadataAsync` function, but not the generated dependency loader function. Fixes #54491 PR Close #54495
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that
@deferblocks weren't recognizing default imports and generating the proper code for them. Default symbols need to be accessed through thedefaultproperty in theimportstatement, rather than by their name.