Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): remove unused EffectRef import statement #53863

Closed
wants to merge 1 commit into from
Closed

refactor(core): remove unused EffectRef import statement #53863

wants to merge 1 commit into from

Conversation

swami-sanapathi
Copy link
Contributor

@swami-sanapathi swami-sanapathi commented Jan 10, 2024 •
edited

PR just removes the unused EffectRef import from to_observable.ts

@pullapprove pullapprove bot requested a review from dylhunn January 10, 2024 06:31
@dylhunn dylhunn added the area: core Issues related to the framework runtime label Jan 17, 2024
@ngbot ngbot bot added this to the Backlog milestone Jan 17, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Jan 17, 2024

caretaker: commit message is sufficient

@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 17, 2024
@swami-sanapathi swami-sanapathi changed the title refactor(core): remove unused import refactor(core): remove unused EffectRef import statement Jan 31, 2024
@pkozlowski-opensource pkozlowski-opensource added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Feb 29, 2024
@pkozlowski-opensource
Copy link
Member

caretaker note: fix the commit message while merging

@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit b322079.

pkozlowski-opensource pushed a commit that referenced this pull request Feb 29, 2024
@swami-sanapathi @pkozlowski-opensource
refactor(core): remove unused EffectRef import statement (#53863)
37dcf8d 
Remove unused, leftover imports.

PR Close #53863
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dylhunn dylhunn dylhunn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swami-sanapathi @dylhunn @pkozlowski-opensource