fix(compiler-cli): interpolatedSignalNotInvoked diagnostic for input signals #53883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
reviewed
Jan 11, 2024
...extended/test/checks/interpolated_signal_not_invoked/interpolated_signal_not_invoked_spec.ts
Outdated
Show resolved
Hide resolved
...es/compiler-cli/src/ngtsc/typecheck/extended/checks/interpolated_signal_not_invoked/index.ts
Show resolved
Hide resolved
cexbrayat
force-pushed
the
fix/interpolated-signal-not-invoked-for-input-signals
branch
2 times, most recently
from
154df79
to
37ff639
Compare
devversion
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Thank you @cexbrayat 🎉
(we can follow-up in the future to reduce a little duplication and maybe even not hard-code symbol names)
Can we also make this a refactor?
devversion
added
action: review
…nput signals This updates the extended diagnotic to handle input signals as well.
cexbrayat
force-pushed
the
fix/interpolated-signal-not-invoked-for-input-signals
branch
from
37ff639
to
6bcff04
Compare
dylhunn
added
area: compiler
dylhunn
approved these changes
Jan 17, 2024
dylhunn
added
action: merge
|
This PR was merged into the repository by commit a7f8d9d. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…nput signals (angular#53883) This updates the extended diagnotic to handle input signals as well. PR Close angular#53883
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…nput signals (angular#53883) This updates the extended diagnotic to handle input signals as well. PR Close angular#53883
danieljancar
pushed a commit
to danieljancar/angular
that referenced
this pull request
Jan 26, 2024
…nput signals (angular#53883) This updates the extended diagnotic to handle input signals as well. PR Close angular#53883
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…nput signals (angular#53883) This updates the extended diagnotic to handle input signals as well. PR Close angular#53883
nikvarma
pushed a commit
to nikvarma/angular
that referenced
this pull request
Jan 31, 2024
…nput signals (angular#53883) This updates the extended diagnotic to handle input signals as well. PR Close angular#53883
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Input signals are not caught by the diagnostic
What is the new behavior?
This updates the extended diagnotic to handle input signals as well.
Does this PR introduce a breaking change?
Other information