Signal queries - runtime bits #54017

pkozlowski-opensource · 2024-01-22T09:50:45Z

No description provided.

packages/core/src/render3/query.ts

packages/core/src/authoring/queries.ts

packages/core/src/linker/query_list.ts

packages/core/src/render3/query_reactive.ts

devversion · 2024-01-22T14:03:08Z

packages/core/src/render3/query_reactive.ts

+})();
+
+export function bindQueryToSignal(target: Signal<unknown>, queryIndex: number): void {
+  const node = target[SIGNAL] as QuerySignalNode<unknown>;


Nit: Also may want to assert here.

Yep, will do in the follow-up!

devversion

LGTM (just follow-up tasks)

packages/core/src/render3/instructions/queries_signals.ts

devversion · 2024-01-22T15:57:57Z

packages/core/src/render3/query_reactive.ts

+function createQuerySignalFn<V>(firstOnly: true, required: true): Signal<V>;
+function createQuerySignalFn<V>(firstOnly: true, required: false): Signal<V|undefined>;
+function createQuerySignalFn<V>(firstOnly: false, required: false): Signal<ReadonlyArray<V>>;
+function createQuerySignalFn<V>(firstOnly: boolean, required: boolean) {


(For follow-up) nit: Would be good to include JSDocs here as well

Agreed, let's do in the follow-up

packages/core/src/linker/query_list.ts

packages/core/src/render3/query_reactive.ts

This is a refactor commit that moves more query construction / refresh logic from the body of instructions into dedicated functions. This is in preparation for the signal-based query instructions.

This refactoring expands the QueryList such that we can add onDirty callback to be invoked when a given query gets marked as dirty during view insertion / removal. This mechanism is needed for signal-based queries.

This commit adds new instructions to support view queries as signals.

jessicajaniuk

reviewed-for: public-api

alxhub

Reviewed-for: public-api

ngbot · 2024-01-24T16:54:33Z

I see that you just added the action: merge label, but the following checks are still failing:
status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

pkozlowski-opensource · 2024-01-24T17:59:35Z

caretaker note: G3 build is green after de-flaking: https://fusion2.corp.google.com/presubmit/600466678/OCL:600466678:BASE:601135515:1706117416930:60e42d7d;groups=PossiblyNewlyFailing/targets

This refactoring expands the QueryList such that we can add onDirty callback to be invoked when a given query gets marked as dirty during view insertion / removal. This mechanism is needed for signal-based queries. PR Close #54017

…54017) This commit adds new instructions to support view queries as signals. PR Close #54017

jessicajaniuk · 2024-01-24T23:39:56Z

This PR was merged into the repository by commit c043128.

…4017) This is a refactor commit that moves more query construction / refresh logic from the body of instructions into dedicated functions. This is in preparation for the signal-based query instructions. PR Close angular#54017

…54017) This refactoring expands the QueryList such that we can add onDirty callback to be invoked when a given query gets marked as dirty during view insertion / removal. This mechanism is needed for signal-based queries. PR Close angular#54017