fix(core): update imports to be compatible with rxjs 6 #54193
Conversation
Peer dependency range allows for rxjs 6. We cannot use features only available in rxjs 7 unless that changes. fixes angular#54192
atscott
added
area: core
| @@ -194,7 +194,7 @@ export class ScheduledComponentFixture<T> extends ComponentFixture<T> { | |||
| if (this.isStable()) { | |||
| return Promise.resolve(false); | |||
| } | |||
| return firstValueFrom(this._appRef.isStable.pipe(filter(stable => stable))); | |||
| return this._appRef.isStable.pipe(first(stable => stable)).toPromise().then(() => true); | |||
There was a problem hiding this comment.
FYI we had to ban first from Components because there was some sort of gotcha where it throws if it completes before emitting. We use take(1) everywhere instead.
There was a problem hiding this comment.
I usually use filter...take(1) as well though in this case was trying to just match what's used in application_ref. FWIW, isStable never completes unless ApplicationRef is disposed.
|
This PR was merged into the repository by commit 3cf612c. |
|
Hi which version of Angular 17 contains this fix? Which packages do I have to change for this fix to work? Is it not yet published on npmjs ? |
|
It will be shiped in next week's patch release ! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Peer dependency range allows for rxjs 6. We cannot use features only available in rxjs 7 unless that changes.
fixes #54192