fix(router): Routed components never inherit RouterOutlet `Environm…
#54265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: router
target: major
angular-robot
bot
added
the
detected: breaking change
atscott
force-pushed
the
routeComponentsNeverInheritOutletEnvironment
branch
from
a70befd
to
887ff89
Compare
jessicajaniuk
approved these changes
Feb 5, 2024
atscott
force-pushed
the
routeComponentsNeverInheritOutletEnvironment
branch
from
bc7afc6
to
79a901c
Compare
pkozlowski-opensource
approved these changes
Feb 19, 2024
…entInjector` This commit ensures components in the route config predictably always get their providers from the hierarchy available to routes rather than sometimes being dependent on where they are inserted. fixes angular#53369 BREAKING CHANGE: Providers available to the routed components always come from the injector heirarchy of the routes and never inherit from the `RouterOutlet`. This means that providers available only to the component that defines the `RouterOutlet` will no longer be available to route components in any circumstances. This was already the case whenever routes defined providers, either through lazy loading an `NgModule` or through explicit `providers` on the route config.
…nvironmentInjector`
atscott
force-pushed
the
routeComponentsNeverInheritOutletEnvironment
branch
from
79a901c
to
217f37a
Compare
|
caretaker note: Will need to patch this change to tracking_router_outlet when sycning cl/608676576 |
atscott
added
merge: caretaker note
|
This PR was merged into the repository by commit da906fd. |
alxhub
added a commit
to alxhub/angular
that referenced
this pull request
Mar 15, 2024
…EnvironmentInjector` (angular#54265)" This reverts commit da906fd. This change causes some test failures in google3.
atscott
added
requires: TGP
alxhub
added a commit
that referenced
this pull request
Mar 15, 2024
atscott
added
action: merge
|
caretaker note: Please merge and sync on its own (and patch the tracking outlet from cl/608676576) |
4 tasks
|
This PR was merged into the repository by commit 3839cfb. |
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this pull request
Apr 6, 2024
…EnvironmentInjector` (angular#54265)" (angular#54895) This reverts commit da906fd. This change causes some test failures in google3. PR Close angular#54895
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this pull request
Apr 6, 2024
…entInjector` (angular#54265) This commit ensures components in the route config predictably always get their providers from the hierarchy available to routes rather than sometimes being dependent on where they are inserted. fixes angular#53369 BREAKING CHANGE: Providers available to the routed components always come from the injector heirarchy of the routes and never inherit from the `RouterOutlet`. This means that providers available only to the component that defines the `RouterOutlet` will no longer be available to route components in any circumstances. This was already the case whenever routes defined providers, either through lazy loading an `NgModule` or through explicit `providers` on the route config. PR Close angular#54265
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
pullapprove
bot
removed
the
requires: TGP
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…entInjector`
This commit ensures components in the route config predictably always get their providers from the hierarchy available to routes rather than sometimes being dependent on where they are inserted.
fixes #53369
BREAKING CHANGE: Providers available to the routed components always come from the injector heirarchy of the routes and never inherit from the
RouterOutlet. This means that providers available only to the component that defines theRouterOutletwill no longer be available to route components in any circumstances. This was already the case whenever routes defined providers, either through lazy loading anNgModuleor through explicitproviderson the route config.