Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): Use string body to generate transfer cache key. #54379

Closed
wants to merge 1 commit into from
Closed

fix(http): Use string body to generate transfer cache key. #54379

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

This is particularly usefull for GraphQL queries where the string body might be the only discriminator.

Fixes #54377

@JeanMeche JeanMeche marked this pull request as ready for review February 11, 2024 12:41
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: common/http target: patch This PR is targeted for the next patch release server: http cache labels Feb 12, 2024
@ngbot ngbot bot added this to the Backlog milestone Feb 12, 2024
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: presubmit The PR is in need of a google3 presubmit labels Feb 12, 2024
@AndrewKushnir
Copy link
Contributor

@JeanMeche it looks like there is a legit CI failure in the test job, see:

TransferCache withHttpTransferCache should stop storing HTTP calls in `TransferState` after application becomes stable FAILED

@JeanMeche
fix(http): Use string body to generate transfer cache key.
aef8c1f 
This is particularly usefull for GraphQL queries where the string body might be the only discriminator.

Fixes angular#54377
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: presubmit The PR is in need of a google3 presubmit labels Feb 13, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 74b5a51.

AndrewKushnir pushed a commit that referenced this pull request Feb 13, 2024
@JeanMeche @AndrewKushnir
fix(http): Use string body to generate transfer cache key. (#54379)
9c486c9 
This is particularly usefull for GraphQL queries where the string body might be the only discriminator.

Fixes #54377

PR Close #54379
AndrewKushnir pushed a commit that referenced this pull request Feb 13, 2024
@JeanMeche @AndrewKushnir
fix(http): Use string body to generate transfer cache key. (#54379)
1c53625 
This is particularly usefull for GraphQL queries where the string body might be the only discriminator.

Fixes #54377

PR Close #54379
atscott pushed a commit to atscott/angular that referenced this pull request Feb 16, 2024
@JeanMeche @atscott
fix(http): Use string body to generate transfer cache key. (angular#5…
87d00f5 
…4379)

This is particularly usefull for GraphQL queries where the string body might be the only discriminator.

Fixes angular#54377

PR Close angular#54379
vladboisa pushed a commit to vladboisa/angular that referenced this pull request Feb 20, 2024
@JeanMeche @vladboisa
fix(http): Use string body to generate transfer cache key. (angular#5…
6a0bc34 
…4379)

This is particularly usefull for GraphQL queries where the string body might be the only discriminator.

Fixes angular#54377

PR Close angular#54379
@JeanMeche JeanMeche deleted the fix/transfer-cache-str-body branch February 29, 2024 13:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfaproject alfaproject alfaproject left review comments

@alan-agius4 alan-agius4 alan-agius4 left review comments

@ahmadshahwan ahmadshahwan ahmadshahwan approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common/http server: http cache target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
5 participants
@JeanMeche @AndrewKushnir @alfaproject @ahmadshahwan @alan-agius4