fix(core): return the same children query results if there are no changes #54392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
area: core
pkozlowski-opensource
added
target: rc
JoostK
approved these changes
Feb 12, 2024
devversion
approved these changes
Feb 12, 2024
pkozlowski-opensource
added
action: merge
…nges Assure that the same readonly array corresponding to the children query results is returned for cases where a query is marked as dirty but there were no actual changes to the content of the results array (this can happen if a view is added and removed thus marking queries as dirty but not influencing final results). Fixes angular#54376
pkozlowski-opensource
force-pushed
the
queries_perf_to_array
branch
from
01f33f9
to
f25ae73
Compare
pkozlowski-opensource
added
the
merge: caretaker note
|
caretaker note: I believe that G3 failures are unrelated, pre-exisiting flakes |
|
This PR was merged into the repository by commit ff62244. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Feb 12, 2024
…nges (#54392) Assure that the same readonly array corresponding to the children query results is returned for cases where a query is marked as dirty but there were no actual changes to the content of the results array (this can happen if a view is added and removed thus marking queries as dirty but not influencing final results). Fixes #54376 PR Close #54392
atscott
pushed a commit
to atscott/angular
that referenced
this pull request
Feb 16, 2024
…nges (angular#54392) Assure that the same readonly array corresponding to the children query results is returned for cases where a query is marked as dirty but there were no actual changes to the content of the results array (this can happen if a view is added and removed thus marking queries as dirty but not influencing final results). Fixes angular#54376 PR Close angular#54392
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Feb 20, 2024
…nges (angular#54392) Assure that the same readonly array corresponding to the children query results is returned for cases where a query is marked as dirty but there were no actual changes to the content of the results array (this can happen if a view is added and removed thus marking queries as dirty but not influencing final results). Fixes angular#54376 PR Close angular#54392
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assure that the same readonly array corresponding to the children query results is returned for cases where a query is marked as dirty but there were no actual changes to the content of the results array (this can happen if a view is added and removed thus marking queries as dirty but not influencing final results).