fix(core): show placeholder block on the server with immediate trigger #54394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all triggers are set up to show the placeholder block on the server, except for `on immediate` which is basically a noop. These changes update `on immediate` to match the rest of the triggers. Fixes angular#54385.
crisbeto
added
action: review
AndrewKushnir
approved these changes
Feb 12, 2024
AndrewKushnir
removed
the
action: review
|
This PR was merged into the repository by commit 383e093. |
atscott
pushed a commit
to atscott/angular
that referenced
this pull request
Feb 16, 2024
angular#54394) Currently all triggers are set up to show the placeholder block on the server, except for `on immediate` which is basically a noop. These changes update `on immediate` to match the rest of the triggers. Fixes angular#54385. PR Close angular#54394
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Feb 20, 2024
angular#54394) Currently all triggers are set up to show the placeholder block on the server, except for `on immediate` which is basically a noop. These changes update `on immediate` to match the rest of the triggers. Fixes angular#54385. PR Close angular#54394
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all triggers are set up to show the placeholder block on the server, except for
on immediatewhich is basically a noop. These changes updateon immediateto match the rest of the triggers.Fixes #54385.