fix(core): prevent infinite loops in clobbered elements check #54425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
action: review
pullapprove
bot
requested review from
jelbourn,
josephperrott and
pkozlowski-opensource
AndrewKushnir
force-pushed
the
clobbering_check_fix
branch
4 times, most recently
from
01fd9df
to
894b81e
Compare
alfaproject
reviewed
Feb 15, 2024
This commit updates HTML sanitization logic to avoid infinite loops in case clobbered elements contain fields like `nextSibling` or `parentNode`. Those fields are used for DOM traversal and this update makes sure that those calls return valid results. Also this commit fixes an issue when clobbering `nodeName` causes JS exceptions.
AndrewKushnir
force-pushed
the
clobbering_check_fix
branch
from
894b81e
to
e92a3f7
Compare
pkozlowski-opensource
approved these changes
Mar 4, 2024
|
Caretaker notes
|
AndrewKushnir
added
action: merge
|
This PR was merged into the repository by commit eaff724. |
atscott
pushed a commit
that referenced
this pull request
Mar 11, 2024
This commit updates HTML sanitization logic to avoid infinite loops in case clobbered elements contain fields like `nextSibling` or `parentNode`. Those fields are used for DOM traversal and this update makes sure that those calls return valid results. Also this commit fixes an issue when clobbering `nodeName` causes JS exceptions. PR Close #54425
atscott
pushed a commit
that referenced
this pull request
Mar 11, 2024
This commit updates HTML sanitization logic to avoid infinite loops in case clobbered elements contain fields like `nextSibling` or `parentNode`. Those fields are used for DOM traversal and this update makes sure that those calls return valid results. Also this commit fixes an issue when clobbering `nodeName` causes JS exceptions. PR Close #54425
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates HTML sanitization logic to avoid infinite loops in case clobbered elements contain fields like
nextSiblingorparentNode. Those fields are used for DOM traversal and this update makes sure that those calls return valid results.Also this commit fixes an issue when clobbering
nodeNamecauses JS exceptions.(more context in the internal ticket: b/323800512)
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?