Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms): Unified Control State Change Events #54579

Closed

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Feb 22, 2024

This commit adds a global observable to subscribe to track changes around any AbstractControl (and its children).

Fixes #10887

@ngbot ngbot bot added this to the Backlog milestone Feb 22, 2024
@JeanMeche JeanMeche added the target: major This PR is targeted for the next major release label Feb 22, 2024
@JeanMeche JeanMeche force-pushed the feat/unified-control-change branch 3 times, most recently from 5b74ab0 to 5cd84a0 Compare February 22, 2024 20:37
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Feb 22, 2024
@JeanMeche JeanMeche force-pushed the feat/unified-control-change branch 2 times, most recently from 33f69ac to f9041b5 Compare February 24, 2024 18:44
Copy link

github-actions bot commented Feb 24, 2024

Deployed adev-preview for 2e47c83 to: https://ng-dev-previews-fw--pr-angular-angular-54579-adev-prev-kz3hd4fk.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche force-pushed the feat/unified-control-change branch 2 times, most recently from 6092738 to 87226b5 Compare February 24, 2024 21:57
@JeanMeche JeanMeche changed the title refactor(forms): Unified Control State Change Events feat(forms): Unified Control State Change Events Feb 25, 2024
@JeanMeche JeanMeche force-pushed the feat/unified-control-change branch 6 times, most recently from 89950f7 to 5f5f1c1 Compare March 9, 2024 14:09
@JeanMeche JeanMeche force-pushed the feat/unified-control-change branch 3 times, most recently from 8b5d725 to 1f96c0c Compare March 9, 2024 21:09
@JeanMeche JeanMeche marked this pull request as ready for review March 9, 2024 21:10
@JeanMeche JeanMeche force-pushed the feat/unified-control-change branch 2 times, most recently from 6e1cd9a to 03bb4eb Compare March 12, 2024 19:36
@dylhunn
Copy link
Contributor

dylhunn commented Apr 3, 2024

caretaker: tgp rerun looks OK, modulo some failures that seem to be preexisting. atscott feedback is addressed.

@dylhunn dylhunn requested review from atscott and removed request for atscott April 3, 2024 16:22
@JeanMeche JeanMeche requested a review from atscott April 3, 2024 16:22
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Apr 3, 2024
@dylhunn dylhunn removed the request for review from atscott April 3, 2024 16:22
@jessicajaniuk jessicajaniuk dismissed atscott’s stale review April 3, 2024 17:11

feedback has been addressed

@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 1c736dc.

@JeanMeche JeanMeche deleted the feat/unified-control-change branch April 3, 2024 18:11
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 3, 2024
This commit introduces a new method to subscribe to on every `AbstractControl` subclass.
It allows to track value, pristine, touched and status changes on a given control.

Fixes angular#10887

PR Close angular#54579
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 3, 2024
This commit introduces a new method to subscribe to on every `AbstractControl` subclass.
It allows to track value, pristine, touched and status changes on a given control.

Fixes angular#10887

PR Close angular#54579
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
This commit introduces a new method to subscribe to on every `AbstractControl` subclass.
It allows to track value, pristine, touched and status changes on a given control.

Fixes angular#10887

PR Close angular#54579
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 8, 2024
This is a refactoring on top of angular#54579 which we weren't able to land because it had breakages in G3 : explicit calls to `emit` on the observables.

Should also fix angular#54418
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 8, 2024
This is a refactoring on top of angular#54579 which we weren't able to land because it had breakages in G3 : explicit calls to `emit` on the observables.

Should also fix angular#54418
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 8, 2024
This is a refactoring on top of angular#54579 which we weren't able to land because it had breakages in G3 : explicit calls to `emit` on the observables.

Should also fix angular#54418
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 8, 2024
This is a refactoring on top of angular#54579 which we weren't able to land because it had breakages in G3 : explicit calls to `emit` on the observables.

Should also fix angular#54418
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 22, 2024
This is a refactoring on top of angular#54579 which we weren't able to land because it had breakages in G3 : explicit calls to `emit` on the observables.

Should also fix angular#54418
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: forms detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unified Control State Change Events (FormControl should also support pristine/touched/untouched/valid events)
5 participants