Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(migrations): resolve infinite loop for a single line element with a long tag name and angle bracket on a new line #54588

Closed
wants to merge 1 commit into from
Closed

fix(migrations): resolve infinite loop for a single line element with a long tag name and angle bracket on a new line #54588

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Fixes an edge case where a single-line elemnt with a long tag name a closing bracket on a new line was putting the control flow migration into an infinite loop.

Fixes #54587.

@crisbeto
fix(migrations): resolve infinite loop for a single line element with…
fb20b98 
… a long tag name and angle bracket on a new line

Fixes an edge case where a single-line elemnt with a long tag name a closing bracket on a new line was putting the control flow migration into an infinite loop.

Fixes angular#54587.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 23, 2024
jessicajaniuk
jessicajaniuk approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love these edge cases. LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 23, 2024
@jessicajaniuk jessicajaniuk added the area: migrations Issues related to `ng update` migrations label Feb 23, 2024
@ngbot ngbot bot added this to the Backlog milestone Feb 23, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Feb 23, 2024

This PR was merged into the repository by commit 71e0c7d.

dylhunn pushed a commit that referenced this pull request Feb 23, 2024
@crisbeto @dylhunn
fix(migrations): resolve infinite loop for a single line element with…
dbe673b 
… a long tag name and angle bracket on a new line (#54588)

Fixes an edge case where a single-line elemnt with a long tag name a closing bracket on a new line was putting the control flow migration into an infinite loop.

Fixes #54587.

PR Close #54588
@dylhunn dylhunn closed this in 71e0c7d Feb 23, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

control-flow command freeze
3 participants
@crisbeto @dylhunn @jessicajaniuk