fix(compiler-cli): identify aliased initializer functions #54609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmit of #54480 which includes a fix of the issue that caused it to be rolled back.
Fixes that initializer functions weren't being recognized if they are aliased (e.g.
import {model as alias} from '@angular/core';
).To do this efficiently, I had to introduce the
ImportedSymbolsTracker
which scans the top-level imports of a file and allows them to be checked quickly, without having to go through the type checker. It will be useful in the future when verifying that that initializer APIs aren't used in unexpected places.I've also introduced tests specifically for the
tryParseInitializerApiMember
function so that we can test it in isolation instead of going through the various functions that call into it.