refactor: replace non output EventEmitter with Subject. #54666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
atscott,
devversion and
pkozlowski-opensource
Semantcly we're shifting away from using `EventEmitter` on non-outputs.
Semantcly we're shifting away from using `EventEmitter` on non-outputs.
JeanMeche
force-pushed
the
refactor/event-emitter
branch
from
c463dd3
to
7093c20
Compare
JeanMeche
added
action: review
pkozlowski-opensource
added
the
area: core
pkozlowski-opensource
approved these changes
Mar 4, 2024
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Mar 26, 2024
Similar to angular#54666 and angular#54665 let replace non-output `EventEmitter` with `Subject`
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Mar 26, 2024
Similar to angular#54666 and angular#54665 let replace non-output `EventEmitter` with `Subject`
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Mar 26, 2024
Similar to angular#54666 and angular#54665 let replace non-output `EventEmitter` with `Subject`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits, 1 form the common package, 1 for the core package.
Same as #54665