Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove @empty <li> from the a11y tree #54676

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alejandrocuba
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The existing examples of the @empty block renders an empty unordered list with a list item containing the text “The list is empty”. This is not a good experience for users with accessibility needs, as pointed out by @ahasall.

Issue Number: N/A

What is the new behavior?

A <li [attr.aria-hidden]="true"> element is now rendered within the @empty block, as the resulting node will be removed from the accessibility tree in the browser.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from dylhunn March 2, 2024 14:17
@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 2, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant