fix(core): ensure all initializer functions run in an injection context #54761
Conversation
crisbeto
added
action: review
crisbeto
force-pushed
the
injection-context-initializers
branch
from
fbfb314
to
493b515
Compare
| // non-required query results are undefined before we run creation mode on the view queries | ||
| const appCmpt = new AppComponent(); | ||
| expect(appCmpt.divEl()).toBeUndefined(); | ||
| it('should return undefined if optional query is read in the constructor', () => { |
There was a problem hiding this comment.
I had to rework these tests, because they were instantiating components manually.
| @Component({template: ''}) | ||
| class TestCmp { | ||
| input = input<number>(0); | ||
| } |
There was a problem hiding this comment.
TestBed.runInInjectionContext(() => input(0)) also works and is shorter.
There was a problem hiding this comment.
Good point, I'll change the input tests but will keep the query tests as they are since they're kinda tied to a view.
Ensures that all of the functions intended to be run in initializers are in an injection context. This is a stop-gap until we have a compiler diagnostic for it.
crisbeto
force-pushed
the
injection-context-initializers
branch
from
493b515
to
31bfdb3
Compare
crisbeto
added
state: blocked
and removed
action: review
|
Blocked on reworking internal targets that are using the functions incorrectly. |
|
Passing TGP, excluding some flakes and after I land a separate cleanup CL. |
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 018f826. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Ensures that all of the functions intended to be run in initializers are in an injection context. This is a stop-gap until we have a compiler diagnostic for it.