-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: explain difference between @placeholder and @loading #54779
docs: explain difference between @placeholder and @loading #54779
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi, thank you for your contribution, can you have a look at the CLA and sign it ? Thank you. |
@JeanMeche I have amended the commit with my Email that has the CLA signed. |
Thanks for the PR @eluchsinger! I submitted a commit to improve the phrasing on the paragraph. Let me know what you think! |
@eluchsinger or @bencodezen can one of you squash the 2 commits ? And we're good to go ! |
Add a sentence to the `@loading` block documentation that emphasizes more that the `@loading` block will replace the `@placeholder` block once the deferred view starts loading.
This PR was merged into the repository by commit 9e60609. |
Add a sentence to the `@loading` block documentation that emphasizes more that the `@loading` block will replace the `@placeholder` block once the deferred view starts loading. PR Close #54779
…4779) Add a sentence to the `@loading` block documentation that emphasizes more that the `@loading` block will replace the `@placeholder` block once the deferred view starts loading. PR Close angular#54779
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add a sentence to the
@loading
block documentation that emphasizes more that the@loading
block will replace the@placeholder
block once the deferred view starts loading.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #54685
What is the new behavior?
Does this PR introduce a breaking change?
Other information