fix(core): ComponentFixture autoDetect respects OnPush flag of …
#54824
+5
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…host view This is a follow-up to angular#53718 that applies the same logic to the `autoDetect` feature of the fixture's host view. This now unifies the logic between `ApplicationRef` and `ComponentFixture` autodetect. BREAKING CHANGE: The `ComponentFixture` `autoDetect` feature will no longer refresh the component's host view when the component is `OnPush` and not marked dirty. This exposes existing issues in components which claim to be `OnPush` but do not correctly call `markForCheck` when they need to be refreshed. If this change causes test failures, the easiest fix is to change the component to `ChangeDetectionStrategy.Default`.
atscott
added
area: testing
angular-robot
bot
added
the
detected: breaking change
AndrewKushnir
approved these changes
Mar 12, 2024
atscott
added
the
action: global presubmit
|
This PR was merged into the repository by commit 8cad4e8. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…host view
This is a follow-up to #53718 that applies the same logic to the
autoDetectfeature of the fixture's host view. This now unifies the logic betweenApplicationRefandComponentFixtureautodetect.BREAKING CHANGE: The
ComponentFixtureautoDetectfeature will no longer refresh the component's host view when the component isOnPushand not marked dirty. This exposes existing issues in components which claim to beOnPushbut do not correctly callmarkForCheckwhen they need to be refreshed. If this change causes test failures, the easiest fix is to change the component toChangeDetectionStrategy.Default.