Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testability): Expose function frameworkStabilizers #5485

Closed
wants to merge 1 commit into from
Closed

feat(testability): Expose function frameworkStabilizers #5485

wants to merge 1 commit into from

Conversation

hankduan
Copy link
Contributor

No description provided.

@hankduan hankduan force-pushed the frameworkStabilizers branch 5 times, most recently from 94ed92f to 16c6428 Compare November 25, 2015 23:44
@hankduan hankduan added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 25, 2015
@hankduan
Copy link
Contributor Author

Julie, can you take a look?

juliemr
juliemr reviewed Dec 1, 2015
View reviewed changes
modules/angular2/src/core/testability/testability.ts
@@ -16,6 +16,8 @@ export class Testability {
/** @internal */
_pendingCount: number = 0;
/** @internal */
_didWork: boolean = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment on what this is for might be useful for someone unfamiliar with the goal of our framework stabilizers.

@juliemr
Copy link
Member

juliemr commented Dec 1, 2015

Sorry for the slow review! Looks like the dart tests are failing. Other than that looks ok.

@juliemr
Copy link
Member

juliemr commented Dec 1, 2015

Also, modify tests at https://github.com/angular/angular/blob/master/modules/angular2/test/core/testability/testability_spec.ts to look for didWork please!

@juliemr juliemr assigned hankduan and unassigned juliemr Dec 1, 2015
@hankduan
Copy link
Contributor Author

hankduan commented Dec 2, 2015

Added comment for didWork and added tests. Still trying to figure out what's wrong with the dart tests ...

@hankduan hankduan force-pushed the frameworkStabilizers branch 10 times, most recently from 19c4f05 to 3530d8c Compare December 3, 2015 22:24
@hankduan
Copy link
Contributor Author

hankduan commented Dec 4, 2015

Still can't figure out what is wrong and angular does not build on my local machine properly, so it's making life difficult.
I'll come back to this in week of 12/14

@hankduan
Copy link
Contributor Author

Ok...slight (although not very useful) update. The same code passes when I run the e2e tests locally =/

@juliemr
Copy link
Member

juliemr commented Dec 18, 2015

This looks good to me! Assigning to @tbosch for a quick sanity check. cc @goderbauer

@juliemr juliemr added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 18, 2015
@juliemr juliemr assigned tbosch and unassigned hankduan Dec 18, 2015
tbosch
tbosch reviewed Dec 21, 2015
View reviewed changes
modules/angular2/src/platform/browser/testability.ts
if (!global.frameworkStabilizers) {
global.frameworkStabilizers = ListWrapper.createGrowableSize(0);
}
global.frameworkStabilizers.push(whenAllStable);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliemr Can we write a test that uses global.frameworkStabilizers?

@tbosch tbosch added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 21, 2015
@tbosch
Copy link
Contributor

tbosch commented Dec 21, 2015

Looks good as well. Would be nice to have a test for the new feature though... (i.e. access global.frameworkStabilizers from an e2e test...

@tbosch tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 21, 2015
@hankduan hankduan force-pushed the frameworkStabilizers branch 3 times, most recently from 0c68225 to 666913a Compare December 21, 2015 22:31
@hankduan
Copy link
Contributor Author

Added e2e test

@tbosch tbosch removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 30, 2015
@tbosch
Copy link
Contributor

tbosch commented Dec 30, 2015

Looks good!

@hankduan hankduan added action: merge The PR is ready for merge by the caretaker zomg_admin: do merge labels Dec 30, 2015
@mary-poppins
Copy link

User @hankduan does not have PR merging privileges.

@hankduan
Copy link
Contributor Author

hankduan commented Jan 5, 2016

squashed both commits together

@mary-poppins
Copy link

Merging PR #5485 on behalf of @rkirov to branch presubmit-rkirov-pr-5485.

@mhevery mhevery closed this in 69ae363 Jan 11, 2016
@rolandjitsu rolandjitsu mentioned this pull request Feb 13, 2016
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@tbosch tbosch

Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hankduan @juliemr @tbosch @mary-poppins @rkirov @googlebot