Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fear(core): Custom Runtime-Error for Template-Execution #54857

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

angelaki
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Right now, template errors can not be told appart from different errors. This can cause infinite loops on the client, if the error gets handled over and over again with a visual element, triggering the template again (in my case a popup dialog).

Issue Number: #53932

What is the new behavior?

Exceptions on executeTemplate throw a custom RuntimeError

Does this PR introduce a breaking change?

  • Yes
  • No

@dylhunn dylhunn added the area: core Issues related to the framework runtime label Mar 27, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues related to the framework runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants